Nutanix mapi: add gpus and dataDisks support #1266
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yanhua121
force-pushed
the
nutanix-gpu-datadisks
branch
from
4783ca2
to
5f27d92
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
yanhua121
force-pushed
the
nutanix-gpu-datadisks
branch
from
5f27d92
to
7939ae4
Compare
|
@yanhua121: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
| if disk.DeviceProperties != nil { | ||
| switch disk.DeviceProperties.DeviceType { | ||
| case machinev1.NutanixDiskDeviceTypeDisk: | ||
| if disk.DeviceProperties.AdapterType != machinev1.NutanixDiskAdapterTypeSCSI && |
There was a problem hiding this comment.
You'd probably be able to make this easier to read if you used a switch statement here and had the default case as the error case
| machinev1.NutanixDiskAdapterTypePCI, machinev1.NutanixDiskAdapterTypeSATA, machinev1.NutanixDiskAdapterTypeSPAPR))) | ||
| } | ||
| case machinev1.NutanixDiskDeviceTypeCDROM: | ||
| if disk.DeviceProperties.AdapterType != machinev1.NutanixDiskAdapterTypeIDE && |
There was a problem hiding this comment.
As above, maybe use a switch?
Update with the api changes for supporting Nutanix gpus and dataDisks:
openshift/api#1935
Add Machine webhooks to validate the newly added Nutanix providerSpec fields.