Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenStack's image reference #187

Merged

Conversation

flaper87
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 31, 2019
@tomassedovic
Copy link
Contributor

This fixes the OpenStack deployment by using the correct actuator image. I've tested it locally and it worked great.

@flaper87
Copy link
Contributor Author

/test e2e-aws-operator
/test e2e-aws

@enxebre
Copy link
Member

enxebre commented Jan 31, 2019

hey @tomassedovic not sure what you mean by test it locally. This shouldn't make any difference unless by testing you mean you run the installer pointing to the release payload built by this PR
You can check it here https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_machine-api-operator/187/pull-ci-openshift-machine-api-operator-master-e2e-aws/381?log#log
Create a new update payload image registry.svc.ci.openshift.org/ci-op-lnqyrfwj/release:latest
Also here you can check how the image is being properly replaced:
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_machine-api-operator/187/pull-ci-openshift-machine-api-operator-master-e2e-aws/381/artifacts/release-latest/release-payload/0000_50_machine-api-operator_01_images.configmap.yaml
"clusterAPIControllerOpenStack": "registry.svc.ci.openshift.org/ci-op-lnqyrfwj/stable@sha256:aa88462f5f3fa095ab6b37a182d2bb95eb95f40b075a24b84176a3667b7778e7",
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2019
@tomassedovic
Copy link
Contributor

tomassedovic commented Jan 31, 2019

@enxebre that's exactly what I did: OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE=registry.svc.ci.openshift.org/ci-op-lnqyrfwj/release:latest

Should have been more explicit in my comment, sorry.

@openshift-merge-robot openshift-merge-robot merged commit fd88da8 into openshift:master Jan 31, 2019
@openshift-ci-robot
Copy link
Contributor

@flaper87: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 0ca7dac link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants