Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add baremetal to the machine-api-manager ClusterRole. #271

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Add baremetal to the machine-api-manager ClusterRole. #271

merged 1 commit into from
Apr 3, 2019

Conversation

russellb
Copy link
Member

@russellb russellb commented Apr 2, 2019

When the machine-api-operator runs the BareMetal machine controller,
it needs access to the BareMetalHost resource. This patch adds that
necessary access to the ClusterRole.

@russellb
Add baremetal to the machine-api-manager ClusterRole.
98e2855 
When the machine-api-operator runs the BareMetal machine controller,
it needs access to the BareMetalHost resource.  This patch adds that
necessary access to the ClusterRole.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2019
@russellb russellb mentioned this pull request Apr 2, 2019
Closed
13 tasks
@vrutkovs
Copy link
Member

vrutkovs commented Apr 3, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 3, 2019 •
edited
Loading

@russellb: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness 98e2855 link /test actuator-pkg-staleness

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Member

/test integration

@ingvagabund
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2019
@enxebre
Copy link
Member

enxebre commented Apr 3, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2019
@openshift-merge-robot openshift-merge-robot merged commit a7b88bf into openshift:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@enxebre enxebre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@russellb @vrutkovs @openshift-ci-robot @ingvagabund @enxebre @openshift-merge-robot