Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodelink-controller: Support multiple internal IPs. #314

Closed
wants to merge 1 commit into from
Closed

nodelink-controller: Support multiple internal IPs. #314

wants to merge 1 commit into from

Conversation

russellb
Copy link
Member

In a baremetal environment, we may have servers with multiple network
interfaces. In that case, the Machine may have multiple internal IPs
listed for the different network interfaces.

This patch makes the nodelink-controller keep track of all Machine
internal IPs so that it can successfully match a Node's internal IP
against whichever IP is being used by the kubelet.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: enxebre

If they are not already assigned, you can assign the PR to them by writing /assign @enxebre in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@russellb russellb mentioned this pull request May 14, 2019
Closed
13 tasks
@vikaschoudhary16
Copy link
Contributor

/lgtm

@enxebre
Copy link
Member

enxebre commented May 15, 2019

can we have a unit test for this?

@russellb
Copy link
Member Author

/test actuator-pkg-staleness

@enxebre
Copy link
Member

enxebre commented May 27, 2019

@russellb would you mind putting a unit for this?

@russellb
Copy link
Member Author

@enxebre sure, sorry I missed the first time you asked that

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2019
@russellb
Copy link
Member Author

@enxebre added tests.

While writing the tests, I noticed that the behavior of updateMachine() looks wrong. It doesn't look at the old copy of the Machine, so if the addresses change, the cache is going to have stale entries in it mapping IPs to an incorrect Machine. I can send a follow-up PR for that, since it's not related to this change.

@russellb
nodelink-controller: Support multiple internal IPs.
71702a0 
In a baremetal environment, we may have servers with multiple network
interfaces.  In that case, the Machine may have multiple internal IPs
listed for the different network interfaces.

This patch makes the nodelink-controller keep track of all Machine
internal IPs so that it can successfully match a Node's internal IP
against whichever IP is being used by the kubelet.

The patch also includes unit test coverage for
add/update/deleteMachine() methods.
@russellb
Copy link
Member Author

russellb commented May 29, 2019 •
edited

I don't see that unit test failure locally, and it looks unrelated to these changes ...

/test unit

@openshift-ci-robot
Copy link
Contributor

@russellb: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness 71702a0 link /test actuator-pkg-staleness
ci/prow/e2e-aws-upgrade 71702a0 link /test e2e-aws-upgrade
ci/prow/e2e-aws-operator 71702a0 link /test e2e-aws-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@russellb
Copy link
Member Author

russellb commented Jun 4, 2019

/rerun

@russellb russellb mentioned this pull request Jun 5, 2019
Merged
@enxebre
Copy link
Member

enxebre commented Jun 6, 2019

@russellb sorry I overlapped with this. Multiple IPs will be now included via #321 so closing this avoid rebasing hassle

@enxebre enxebre closed this Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@vikaschoudhary16 vikaschoudhary16 Awaiting requested review from vikaschoudhary16

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@russellb @openshift-ci-robot @vikaschoudhary16 @enxebre