Marking a couple of fields in the BaremetalHost CRD optional #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
|
/test e2e-aws |
sadasu
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Note for reviewers that openshift/baremetal-operator#44 which was a dependency for this landed. @sadasu I think you also need to remove the WIP from the commit message? |
A couple of fields in the BaremetalHost CRD are being marked as optional as part of metal3-io/baremetal-operator#322. Keeping the BaremetalHost CRD in the MAO current with those changes.
|
/test e2e-aws-upgrade |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelgugino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of fields in the BaremetalHost CRD are being marked as
optional as part of metal3-io/baremetal-operator#322.
Keeping the BaremetalHost CRD in the MAO current with those changes.