Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vsphere #447

Merged
merged 7 commits into from Dec 20, 2019
Merged

Vsphere #447

merged 7 commits into from Dec 20, 2019

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Dec 13, 2019

This introduces a basic vSphere implementation and limited ability to create/update machines so we can follow up in a collaborative manner.
Logic for interacting with vCenter is mostly based from https://github.com/kubernetes-sigs/cluster-api-provider-vsphere

Tested with

apiVersion: v1
kind: Secret
metadata:
 name: vsphere
 namespace: test
type: Opaque
data:
 user: echo -n 'user' | openssl base64
 password: echo -n 'password' | openssl base64

and

apiVersion: machine.openshift.io/v1beta1
kind: Machine
metadata:
  finalizers:
  - machine.machine.openshift.io
  labels:
    machine.openshift.io/cluster-api-cluster: agl091219-wd4n9
  name: test
  namespace: test
spec:
  metadata:
    creationTimestamp: null
  providerSpec:
    value:
      template: "templateValue"
      credentialsSecret: 
        name: "vsphere"
      workspace:
        datacenter: "Datacenter"
        server: "server"
        folder: "machine-api-dev"

Follow ups:
support userdata
support network/disk devices
set providerID

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 13, 2019
Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

I have not had a chance to run this yet to be honest, but it looks like a good start. I think we can merge this and unblock ourselves on further progress and testing.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 425f031 into openshift:master Dec 20, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2019

@enxebre: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 c7aa4ab link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-azure c7aa4ab link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants