Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsphere: Reconcile region and zone labels on Machine #471

Merged
merged 2 commits into from Jan 27, 2020
Merged

vsphere: Reconcile region and zone labels on Machine #471

merged 2 commits into from Jan 27, 2020

Conversation

bison
Copy link
Contributor

@bison bison commented Jan 17, 2020 •
edited

This reconciles the labels on Machine objects used for region and zone
information. In order to do so, the vSphere cloud provider must be
configured with the names of tags identifying this information.

https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/zones.html

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2020
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2020
@bison bison changed the title [WIP] vsphere: Add region and zone labels vsphere: Reconcile region and zone labels on Machine Jan 21, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2020
@bison
Copy link
Contributor Author

bison commented Jan 21, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020
@enxebre
Copy link
Member

enxebre commented Jan 21, 2020

can we move the vendor commit into its own?

@bison
Copy link
Contributor Author

bison commented Jan 21, 2020

can we move the vendor commit into its own?

Done.

@bison
Copy link
Contributor Author

bison commented Jan 24, 2020

/hold cancel

This seems to be working now:

$ kubectl -n vsphere get machines
NAME               PHASE         TYPE   REGION      ZONE         AGE
bison-vsphere-1a   Provisioned          us-east-1   us-east-1a   2m12s
bison-vsphere-1b   Provisioned          us-east-1   us-east-1b   104s

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020
@bison
Copy link
Contributor Author

bison commented Jan 25, 2020

/retest

1 similar comment
@bison
Copy link
Contributor Author

bison commented Jan 26, 2020

/retest

enxebre
enxebre reviewed Jan 27, 2020
View reviewed changes
cmd/vsphere/main.go Outdated Show resolved Hide resolved
@enxebre
Copy link
Member

enxebre commented Jan 27, 2020

other than 131ebeb#r371222161 lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@bison
vsphere: Reconcile region and zone labels on Machine
0ef3ed2 
This reconciles the labels on Machine objects used for region and zone
information. In order to do so, the vSphere cloud provider must be
configured with the names of tags identifying this information.

https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/zones.html
JoelSpeed
JoelSpeed approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@enxebre enxebre mentioned this pull request Jan 27, 2020
Closed
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 33a640c into openshift:master Jan 27, 2020
@openshift-ci-robot
Copy link
Contributor

@bison: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure-operator 797fa4d link /test e2e-azure-operator
ci/prow/e2e-aws-scaleup-rhel7 797fa4d link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bison bison deleted the vsphere-labels branch January 28, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@JoelSpeed JoelSpeed JoelSpeed approved these changes

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bison @enxebre @openshift-ci-robot @openshift-bot @JoelSpeed @openshift-merge-robot