Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1800423: Apply the reboot annotation to the machine #475

Merged
merged 2 commits into from Feb 11, 2020

Conversation

beekhof
Copy link
Contributor

@beekhof beekhof commented Jan 23, 2020

Discussing with the metal3 folks, we’d like to watch the machine for the annotation instead if the node. This avoids the creation of a controller that just relays the annotation from the node to the machine.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 23, 2020
Discussing with the metal3 folks, we’d like to watch the machine for the annotation instead if the node. This avoids the creation of a controller that just relays the annotation from the node to the machine.
@beekhof
Copy link
Contributor Author

beekhof commented Jan 23, 2020

/assign @ingvagabund

@enxebre
Copy link
Member

enxebre commented Jan 23, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020
@beekhof beekhof changed the title Apply the reboot annotation to the machine Bug 1800423 - Apply the reboot annotation to the machine Feb 7, 2020
@beekhof
Copy link
Contributor Author

beekhof commented Feb 7, 2020

Re-executed the tests, the failures do not appear related to this PR

@beekhof beekhof changed the title Bug 1800423 - Apply the reboot annotation to the machine Bug 1800423: Apply the reboot annotation to the machine Feb 7, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 7, 2020
@openshift-ci-robot
Copy link
Contributor

@beekhof: This pull request references Bugzilla bug 1800423, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1800423: Apply the reboot annotation to the machine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@beekhof
Copy link
Contributor Author

beekhof commented Feb 10, 2020

/retest tide

@beekhof
Copy link
Contributor Author

beekhof commented Feb 11, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 11, 2020
@openshift-ci-robot
Copy link
Contributor

@beekhof: This pull request references Bugzilla bug 1800423, which is valid. The bug has been moved to the POST state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@beekhof
Copy link
Contributor Author

beekhof commented Feb 11, 2020

/retest

@beekhof
Copy link
Contributor Author

beekhof commented Feb 11, 2020

/cc @bison or @michaelgugino - could i trouble one of you for a review and lgtm please?
Test failures are not related to this code (mostly etcd failures)

Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 65f3660 into openshift:master Feb 11, 2020
@openshift-ci-robot
Copy link
Contributor

@beekhof: All pull requests linked via external trackers have merged. Bugzilla bug 1800423 has been moved to the MODIFIED state.

In response to this:

Bug 1800423: Apply the reboot annotation to the machine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@beekhof: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure-operator 1216944 link /test e2e-azure-operator
ci/prow/e2e-azure 1216944 link /test e2e-azure
ci/prow/e2e-aws-scaleup-rhel7 1216944 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants