Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSphere: Provider Credentials #479

Merged
merged 3 commits into from Jan 28, 2020
Merged

VSphere: Provider Credentials #479

merged 3 commits into from Jan 28, 2020

Conversation

patrickdillon
Copy link
Contributor

Creates a credentials request to retrieve VSphere creds. Update provider to expect credentials in required format: https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/k8s-secret.html

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 24, 2020
@patrickdillon
Copy link
Contributor Author

cc @jcpowermac @sdodson

@jcpowermac
Copy link
Contributor

Looks right to me

@patrickdillon patrickdillon force-pushed the vsphere-creds branch 7 times, most recently from cf42b0c to 22dec16 Compare January 24, 2020 21:07
@patrickdillon
Copy link
Contributor Author

/test unit

@enxebre
Copy link
Member

enxebre commented Jan 27, 2020

Thanks! the desc says Creates a credentials request to retrieve VSphere creds but I can't see that in the PR. Also can we modify the commit to have an imperative action https://chris.beams.io/posts/git-commit/ e.g "VSphere: Update getCredentialsSecret assumptions to match storage docs conventions https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/k8s-secret.html"

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2020
@patrickdillon patrickdillon force-pushed the vsphere-creds branch 3 times, most recently from a12c9db to e245f71 Compare January 28, 2020 02:57
@patrickdillon
VSphere: Update expected cloud credentials secret format
791d7bd 
The VSphere getCredentialsSecret should expect the secret to be in the format in line with the VSphere storage docs:
https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/k8s-secret.html
@patrickdillon
Copy link
Contributor Author

@enxebre thanks for your review. this should be ready for another look.

@enxebre
Copy link
Member

enxebre commented Jan 28, 2020

/retest

@enxebre
Copy link
Member

enxebre commented Jan 28, 2020

thanks @patrickdillon, looks great to me. @bison PTAL
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
bison
bison approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2d4761b into openshift:master Jan 28, 2020
@openshift-ci-robot
Copy link
Contributor

@patrickdillon: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-operator 791d7bd link /test e2e-gcp-operator
ci/prow/e2e-gcp 791d7bd link /test e2e-gcp
ci/prow/e2e-azure 791d7bd link /test e2e-azure
ci/prow/e2e-aws-scaleup-rhel7 791d7bd link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@bison bison bison approved these changes

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

Assignees

@bison bison

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@patrickdillon @jcpowermac @enxebre @openshift-ci-robot @bison @openshift-merge-robot