Bug 1733474: Add log message when draining the unreachable node #488
Conversation
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@alexander-demichev: This pull request references Bugzilla bug 1733474, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/XS
|
/bugzilla refresh |
|
@enxebre: This pull request references Bugzilla bug 1733474, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/controller/machine/controller.go
Outdated
| @@ -347,6 +347,7 @@ func (r *ReconcileMachine) drainNode(machine *machinev1.Machine) error { | |||
| } | |||
|
|
|||
| if nodeIsUnreachable(node) { | |||
| klog.Infof("Node %q is unreachable, draining will wait for pod deletion for %q seconds and skip after it", node.Name, skipWaitForDeleteTimeoutSeconds) | |||
There was a problem hiding this comment.
may be somehow clarify this is skipWaitForDeleteTimeoutSeconds seconds starting when the pod is signalled for deletion, otherwise every time this is logged cause the impression there's skipWaitForDeleteTimeoutSeconds left to timeout
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@enxebre: This pull request references Bugzilla bug 1733474, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
alexander-demicev
force-pushed
the
drainlogs
branch
from
33de1d2
to
b2b1b3a
Compare
alexander-demicev
force-pushed
the
drainlogs
branch
from
b2b1b3a
to
612266f
Compare
|
/lgtm |
|
/retest |
|
@alexander-demichev: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
We can always add an event later if needed, this is good enough for now, it's not really info we should need all that much and would be in any must-gather thanks to logs. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelgugino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@alexander-demichev: All pull requests linked via external trackers have merged. Bugzilla bug 1733474 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add log message when draining the unreachable node.