update deployment link on readme #494
Conversation
in the dev section there are instructions for running on vanilla kubernetes, this change fixes the broken link for the deployment manifest step.
openshift-ci-robot
added
the
size/XS
|
the only question i have is, do we need an extra step for the kube-rbac-proxy configmap since we've added that to the deployment pod? |
|
/assign @bison |
There was a problem hiding this comment.
the only question i have is, do we need an extra step for the kube-rbac-proxy configmap since we've added that to the deployment pod?
Yeah, this change looks good, but these instructions are generally outdated. I personally don't think it's worth it to put much effort into supporting anything other than OpenShift. The operator's purpose is to act as an integration point for the cluster-api and OpenShift.
/lgtm
|
thanks @bison, maybe i'll just make a followup to remove these instructions after talking with the group a little. |
|
Agree with #494 (review) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
in the dev section there are instructions for running on vanilla
kubernetes, this change fixes the broken link for the deployment
manifest step.