Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't oscillate between Degraded and Progressing status #507

Merged
merged 2 commits into from Mar 12, 2020
Merged

Don't oscillate between Degraded and Progressing status #507

merged 2 commits into from Mar 12, 2020

Conversation

bison
Copy link
Contributor

@bison bison commented Mar 6, 2020

This changes the behavior of the statusProgressing and statusDegraded methods to not modify other unrelated status conditions. The previous behavior was causing the ClusterOperator status to oscillate between Degraded and Progressing when there was a problem syncing the deployments, because each transition was overwriting the other.

This also changes the initial creation of the ClusterOperator resource to set default status conditions.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2020
@bison bison changed the title [WIP] Don't oscillate between Degraded and Progressing status Don't oscillate between Degraded and Progressing status Mar 11, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2020
@bison
Copy link
Contributor Author

bison commented Mar 11, 2020

/test unit

@bison
Copy link
Contributor Author

bison commented Mar 11, 2020

/retest

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo, but otherwise LGTM

pkg/operator/status.go Outdated Show resolved Hide resolved
This changes the behavior of the `statusProgressing` and
`statusDegraded` methods to not modify other unrelated status
conditions.  The previous behavior was causing the ClusterOperator
status to oscillate between Degraded and Progressing when there was a
problem syncing the deployments.
@enxebre
Copy link
Member

enxebre commented Mar 12, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2020
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2020
@openshift-merge-robot openshift-merge-robot merged commit f966502 into openshift:master Mar 12, 2020
@bison bison deleted the OCPCLOUD-797 branch March 12, 2020 13:44
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 12, 2020

@bison: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 74fc2b4 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-azure 74fc2b4 link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants