New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't oscillate between Degraded and Progressing status #507
Conversation
/test unit |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a typo, but otherwise LGTM
This changes the behavior of the `statusProgressing` and `statusDegraded` methods to not modify other unrelated status conditions. The previous behavior was causing the ClusterOperator status to oscillate between Degraded and Progressing when there was a problem syncing the deployments.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@bison: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This changes the behavior of the
statusProgressing
andstatusDegraded
methods to not modify other unrelated status conditions. The previous behavior was causing the ClusterOperator status to oscillate between Degraded and Progressing when there was a problem syncing the deployments, because each transition was overwriting the other.This also changes the initial creation of the ClusterOperator resource to set default status conditions.