Add unit tests for vsphere reconciler #509
Conversation
openshift-ci-robot
added
the
size/L
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
|
||
| reconciler := newReconciler(&machineScope) | ||
|
|
||
| err = reconciler.create() |
There was a problem hiding this comment.
If you change this to err := does the linter mark it as shadowing? Just wondering if it's better to scope this error within each t.Run invocation, WDYT?
There was a problem hiding this comment.
You're right, but linter seems to be fine with it
| }) | ||
| } | ||
| } | ||
| func TestUpdate(t *testing.T) { |
There was a problem hiding this comment.
Nit: I'd add a new line above this one between these two tests
|
|
||
| reconciler := newReconciler(&machineScope) | ||
|
|
||
| if tc.labels != nil { |
There was a problem hiding this comment.
Can we move this above creating machineScope so that it matches the pattern in the one above? (Or switch the other to look like this, I don't mind either way, just looking for consistency)
| reconciler.machine.Labels = tc.labels | ||
| } | ||
|
|
||
| err = reconciler.update() |
There was a problem hiding this comment.
Similar question WRT the scope of this error as above 🤔
alexander-demicev
force-pushed
the
testvsphere
branch
from
c0e955e
to
7106a41
Compare
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@alexander-demichev: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Add unit tests for vsphere reconciler. I will open a followup PR with new test cases later.