Bug 1811161: ROKS - remove machine related CRDs from cluster [4.4]

[csrwng]

In a ROKS cluster, the console UI should not show machine related views since
machine management is done outside the cluster. The UI will remove the
views as long as the CRDs are not present.

[openshift-ci-robot]

@csrwng: This pull request references Bugzilla bug 1809333, which is invalid:

• expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
• expected Bugzilla bug 1809333 to depend on a bug targeting the "4.5.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1809333: ROKS - remove machine related CRDs from cluster [4.4]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@csrwng: This pull request references Bugzilla bug 1811161, which is invalid:

• expected dependent Bugzilla bug 1809333 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1811161: ROKS - remove machine related CRDs from cluster [4.4]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enxebre]

/retest
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[csrwng]

/bugzilla refresh

[openshift-ci-robot]

@csrwng: This pull request references Bugzilla bug 1811161, which is invalid:

• expected dependent Bugzilla bug 1809333 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sdodson]

/bugzilla refresh

[openshift-ci-robot]

@sdodson: This pull request references Bugzilla bug 1811161, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.4.0) matches configured target release for branch (4.4.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1809333 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1809333 targets the "4.5.0" release, matching the expected (4.5.0) release
• bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[michaelgugino]

Is there a way to do this in go code rather than here?

[csrwng]

You mean a go program to invoke the original gen tool?

[csrwng]

Definitely, if there's a better way to do it, then we should create an issue for it. However, this already went in to master and all we're trying to do is backport it to 4.4 and 4.3.

[enxebre]

yeh there's OCPCLOUD-809 to follow up on this separately. We should probably use kustomize or similar for the long term.

[elmiko]

this looks reasonable to me. i'm holding off on adding lgtm label to see what happens with @michaelgugino 's comment

[michaelgugino]

/lgtm

[michaelgugino]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@csrwng: All pull requests linked via external trackers have merged. Bugzilla bug 1811161 has been moved to the MODIFIED state.

In response to this:

Bug 1811161: ROKS - remove machine related CRDs from cluster [4.4]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@csrwng: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-azure	45890e1	link	/test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.