Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User FAQ #534

Merged

Conversation

michaelgugino
Copy link
Contributor

No description provided.

FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated
This is set via the MCO’s config, not the machine-api. The config a machine receives upon boot is decided by the machine's user-data.

## How does the user-data get created for the VMs?
The user-data is generated by the installer. The machine-api is just a consumer of the user-data and simply passes the data to the cloud. Refer to documentation for the machine-config-operator (not part of the machine-api) for creating new machine pools and user-data.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good doc link for this?

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this, thanks for putting it up @michaelgugino

sadly, i don't have answers for your questions

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, covers a lot of the basic questions. Added a few suggestions while reading throught

ONe more suggestion is that we ensure resource names are capitalised throughout (eg Node, Machine, etc) as currently there is a mix of capitalised and un-capitalised resource names

FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated
The user-data is generated by the installer. The machine-api is just a consumer of the user-data and simply passes the data to the cloud. Refer to documentation for the machine-config-operator (not part of the machine-api) for creating new machine pools and user-data.

## Adding Labels to Nodes via Machines
Labels are only added to nodes via machines at creation time. You can add arbitrary labels which are applied to nodes immediately after they join the cluster. Adding subsequent labels on the machine object (or in a machineset’s template) will have no effect.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be add the api path to the label here, that's usually confusing as there're multiple labels

@elmiko
Copy link
Contributor

elmiko commented Apr 16, 2020

i love this, thanks Mike!

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2020
@enxebre
Copy link
Member

enxebre commented Apr 17, 2020

thanks!
/retest
/lgtm

@openshift-ci-robot
Copy link
Contributor

@enxebre: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-operator
  • /test e2e-aws-operator-tech-preview
  • /test e2e-aws-scaleup-rhel7
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-azure-operator
  • /test e2e-gcp
  • /test e2e-gcp-operator
  • /test e2e-openstack
  • /test goimports
  • /test golint
  • /test govet
  • /test images
  • /test unit
  • /test yaml-lint

Use /test all to run all jobs.

In response to this:

/retest
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020
@michaelgugino
Copy link
Contributor Author

/retest

2 similar comments
@michaelgugino
Copy link
Contributor Author

/retest

@michaelgugino
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

@michaelgugino: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 2f72228 link /test e2e-gcp
ci/prow/e2e-aws-scaleup-rhel7 2f72228 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-azure-operator 2f72228 link /test e2e-azure-operator
ci/prow/e2e-azure 2f72228 link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit bd3acbd into openshift:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants