New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add User FAQ #534
Add User FAQ #534
Conversation
FAQ.md
Outdated
This is set via the MCO’s config, not the machine-api. The config a machine receives upon boot is decided by the machine's user-data. | ||
|
||
## How does the user-data get created for the VMs? | ||
The user-data is generated by the installer. The machine-api is just a consumer of the user-data and simply passes the data to the cloud. Refer to documentation for the machine-config-operator (not part of the machine-api) for creating new machine pools and user-data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good doc link for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like this, thanks for putting it up @michaelgugino
sadly, i don't have answers for your questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, covers a lot of the basic questions. Added a few suggestions while reading throught
ONe more suggestion is that we ensure resource names are capitalised throughout (eg Node, Machine, etc) as currently there is a mix of capitalised and un-capitalised resource names
FAQ.md
Outdated
The user-data is generated by the installer. The machine-api is just a consumer of the user-data and simply passes the data to the cloud. Refer to documentation for the machine-config-operator (not part of the machine-api) for creating new machine pools and user-data. | ||
|
||
## Adding Labels to Nodes via Machines | ||
Labels are only added to nodes via machines at creation time. You can add arbitrary labels which are applied to nodes immediately after they join the cluster. Adding subsequent labels on the machine object (or in a machineset’s template) will have no effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be add the api path to the label here, that's usually confusing as there're multiple labels
i love this, thanks Mike! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks! |
@enxebre: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
2 similar comments
/retest |
/retest |
@michaelgugino: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.