New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OCPCLOUD-815] Use MachineSet controller from MAO image #546
[OCPCLOUD-815] Use MachineSet controller from MAO image #546
Conversation
@@ -9,6 +9,7 @@ require ( | |||
github.com/google/uuid v1.1.1 | |||
github.com/hashicorp/golang-lru v0.5.3 // indirect | |||
github.com/imdario/mergo v0.3.8 // indirect | |||
github.com/onsi/gomega v1.8.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:face_with_raised_eyebrow:
shall we include a commit to rename the binary in the kube deployment, the Dockerfile and the Make file? e.g manager -> machineSet |
@enxebre Renaming seems good, have added another commit to rename to |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This changes the image for the MachineSet controller deployed in the
machine-api-controllers
deployment to use themachine-api-operator
image instead of theprovider
image.Also adds tests to check the output of
maoConfigFromInfrastructure
as this was not previously tested