New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG 1862556: Ensure that negative values for maxUnhealthy do not produce events #680

Merged

openshift-merge-robot merged 1 commit into openshift:master from JoelSpeed:negative-maxunhealthy

Aug 19, 2020

Contributor

JoelSpeed commented Aug 17, 2020

Previously, we were producing a remediation restricted event every reconcile if a maxUnhealthy value is negative.
We can only validate the maxUnhealthy integer value by creating a webhook which is a substantial amount of work, this is a quicker fix that makes the behaviour of a negative value identical to that of a 0 value.


          Ensure that negative values for maxUnhealthy do not produce events

a3960f6

Previously, we were producing a remediation restricted event every 
reconcile if a maxUnhealthy value is negative.
We can only validate the maxUnhealthy integer value by creating a 
webhook which is a substantial amount of work, this is a quicker fix 
that makes the behaviour of a negative value identical to that of a 0 
value.

Contributor

openshift-ci-robot commented Aug 17, 2020

@JoelSpeed: This pull request references Bugzilla bug 1862556, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

BUG 1862556: Ensure that negative values for maxUnhealthy do not produce events

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-low bugzilla/valid-bug labels

openshift-ci-robot requested review from cynepco3hahue and paulfantom

August 17, 2020 15:16

alexander-demicev approved these changes

View reviewed changes

Contributor

alexander-demicev left a comment

/approve

Contributor

openshift-ci-robot commented Aug 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/controller/machinehealthcheck/OWNERS~~ [alexander-demichev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the approved label

Contributor Author

JoelSpeed commented Aug 18, 2020

/retest

Contributor Author

JoelSpeed commented Aug 18, 2020

/test e2e-aws

elmiko approved these changes

View reviewed changes

Contributor

elmiko left a comment

this change lgtm, i do wonder if we need to document this behavior somewhere? (it seems pretty corner case)
/lgtm

openshift-ci-robot assigned elmiko

openshift-ci-robot added the lgtm label

Contributor

openshift-bot commented Aug 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment

Contributor

openshift-bot commented Aug 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor Author

JoelSpeed commented Aug 19, 2020

/retest

Contributor

openshift-bot commented Aug 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments

Contributor

openshift-bot commented Aug 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Aug 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-ci-robot commented Aug 19, 2020 •

edited

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-workers-rhel7	`a3960f6`	link	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-gcp-operator	`a3960f6`	link	`/test e2e-gcp-operator`
ci/prow/e2e-azure	`a3960f6`	link	`/test e2e-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot merged commit 79ac5f8 into openshift:master

Contributor

openshift-ci-robot commented Aug 19, 2020

@JoelSpeed: All pull requests linked via external trackers have merged: openshift/machine-api-operator#680, openshift/machine-api-operator#650. Bugzilla bug 1862556 has been moved to the MODIFIED state.

In response to this:

BUG 1862556: Ensure that negative values for maxUnhealthy do not produce events

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment