Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation section for 'mapi_instance_OP_failed' metrics #717

Merged
merged 1 commit into from Oct 22, 2020
Merged

Add documentation section for 'mapi_instance_OP_failed' metrics #717

merged 1 commit into from Oct 22, 2020

Conversation

Danil-Grigorev
Copy link
Contributor

Added section to the documentation explains typical use-cases these metrics should cover.

JoelSpeed
JoelSpeed reviewed Oct 5, 2020
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, added a couple of suggestions to make the new section try to feel more uniform with the rest of the doc, let me know what you think

docs/dev/metrics.md Outdated Show resolved Hide resolved
docs/dev/metrics.md Outdated Show resolved Hide resolved
docs/dev/metrics.md Outdated Show resolved Hide resolved
JoelSpeed
JoelSpeed approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2020
alexander-demicev
alexander-demicev approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020
michaelgugino
michaelgugino approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

elmiko
elmiko suggested changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this new section cuts another section in half
/hold

docs/dev/metrics.md
@@ -88,6 +88,26 @@ In addition, Prometheus provides some default metrics about the internal state
of the running process and the metric collection. You can find more information
about these metric names and their labels through the following links:

## Machine API error rate for provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the placement of this section cuts the "Metrics about the Prometheus collectors" in half. this new section should be moved to line 73 at the least.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2020
@openshift-ci-robot
Copy link
Contributor

@Danil-Grigorev: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi bd8c997 link /test e2e-metal-ipi
ci/prow/e2e-gcp-operator bd8c997 link /test e2e-gcp-operator
ci/prow/e2e-aws-upgrade bd8c997 link /test e2e-aws-upgrade
ci/prow/e2e-gcp bd8c997 link /test e2e-gcp
ci/prow/e2e-aws bd8c997 link /test e2e-aws
ci/prow/e2e-aws-operator bd8c997 link /test e2e-aws-operator
ci/prow/e2e-aws-workers-rhel7 bd8c997 link /test e2e-aws-workers-rhel7
ci/prow/e2e-azure bd8c997 link /test e2e-azure
ci/prow/e2e-azure-operator bd8c997 link /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2020
@Danil-Grigorev
Copy link
Contributor Author

/hold cancel
@elmiko good catch! PTAL

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2020
@openshift-merge-robot
Copy link
Contributor

@Danil-Grigorev: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-operator 9e4f67a link /test e2e-gcp-operator
ci/prow/e2e-azure 9e4f67a link /test e2e-azure
ci/prow/e2e-azure-operator 9e4f67a link /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

elmiko
elmiko approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Danil!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit c1f0af9 into openshift:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko approved these changes

@michaelgugino michaelgugino michaelgugino approved these changes

@JoelSpeed JoelSpeed JoelSpeed approved these changes

@alexander-demicev alexander-demicev alexander-demicev approved these changes

Assignees

@elmiko elmiko

@michaelgugino michaelgugino

@alexander-demicev alexander-demicev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Danil-Grigorev @openshift-ci-robot @openshift-merge-robot @elmiko @michaelgugino @JoelSpeed @alexander-demicev