Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add current profile annotations to CVO manifests #738

Merged
merged 1 commit into from Oct 26, 2020

Conversation

guillaumerose
Copy link
Contributor

This is matches openshift/enhancements#510 and doesn't change existing behavior

This is matches openshift/enhancements#510 and doesn't change existing behavior
@openshift-merge-robot
Copy link
Contributor

@guillaumerose: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-operator 3318089 link /test e2e-gcp-operator
ci/prow/e2e-gcp 3318089 link /test e2e-gcp
ci/prow/e2e-metal-ipi 3318089 link /test e2e-metal-ipi
ci/prow/e2e-azure 3318089 link /test e2e-azure
ci/prow/e2e-azure-operator 3318089 link /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Oct 26, 2020

The annotation looks correct.

I don't really speak bash for that script.

/assign @enxebre

@enxebre
Copy link
Member

enxebre commented Oct 26, 2020

/approve
PTAL @JoelSpeed

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2020
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9fc905e into openshift:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants