Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1889620: Azure disconnected reject publicIP setting #746

Merged
merged 2 commits into from Nov 11, 2020
Merged

Bug 1889620: Azure disconnected reject publicIP setting #746

merged 2 commits into from Nov 11, 2020

Conversation

Danil-Grigorev
Copy link
Contributor

Disconnected installations are using different DNS settings, and this is displayed in the resource

apiVersion: config.openshift.io/v1
kind: DNS
metadata:
  name: cluster
spec:
  baseDomain: ***
  privateZone:
    id: <id>
  publicZone: <- this field is absent in disconnected install
    id: <id>

The PR goal is to reject an invalid MachineSet configuration when a publicIP: true, to prevent Machine from failing.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 10, 2020
@openshift-ci-robot
Copy link
Contributor

@Danil-Grigorev: This pull request references Bugzilla bug 1889620, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1889620: Azure disconnected reject publicIP setting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elmiko
elmiko approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2020
@JoelSpeed
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Danil-Grigorev
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2020
@Danil-Grigorev
Add RBAC for DNS and config for webhooks
6501c89
@Danil-Grigorev
Add tests for Azure disconnected installation.
eae2213 
- Check the requirement on DNS configuration, before creating machine with publicIP.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020
@Danil-Grigorev
Copy link
Contributor Author

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2020
@Danil-Grigorev
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Contributor

@Danil-Grigorev: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt eae2213 link /test e2e-libvirt
ci/prow/e2e-azure-operator eae2213 link /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

elmiko
elmiko approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit 77300d0 into openshift:master Nov 11, 2020
@openshift-ci-robot
Copy link
Contributor

@Danil-Grigorev: All pull requests linked via external trackers have merged:

Bugzilla bug 1889620 has been moved to the MODIFIED state.

In response to this:

Bug 1889620: Azure disconnected reject publicIP setting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Danil-Grigorev Danil-Grigorev mentioned this pull request Nov 12, 2020
Merged
@Danil-Grigorev Danil-Grigorev mentioned this pull request Mar 1, 2021
Merged
@Danil-Grigorev
Copy link
Contributor Author

/cherrypick release-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 1, 2021
Closed
@openshift-cherrypick-robot
Copy link

@Danil-Grigorev: new pull request created: #813

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko approved these changes

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@elmiko elmiko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Danil-Grigorev @openshift-ci-robot @JoelSpeed @openshift-bot @openshift-merge-robot @openshift-cherrypick-robot @elmiko