Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mapi_machinehealthcheck_remediation_success_total metric #754

Merged
merged 1 commit into from Nov 23, 2020
Merged

add mapi_machinehealthcheck_remediation_success_total metric #754

merged 1 commit into from Nov 23, 2020

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Nov 17, 2020

This change adds a counter metric for successful remediations, it also adds a helper function to increase the counter and documentation about the new metric.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2020
@openshift-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@elmiko
Copy link
Contributor Author

elmiko commented Nov 17, 2020

creating this as draft while i do some manual testing

this will need to go after #752

@elmiko elmiko changed the title Add mhc successful remediations metric add mapi_machinehealthcheck_remediation_success_total metric Nov 17, 2020
@elmiko elmiko force-pushed the add-mhc-successful-remediations-metric branch 2 times, most recently from ab915af to 08917b2 Compare November 17, 2020 16:44
@elmiko elmiko marked this pull request as ready for review November 17, 2020 16:45
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2020
@elmiko
Copy link
Contributor Author

elmiko commented Nov 17, 2020

this is ready for review, but will need to wait for the other pr
/hold waiting for #752

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2020
@elmiko elmiko mentioned this pull request Nov 17, 2020
Merged
@elmiko
Copy link
Contributor Author

elmiko commented Nov 17, 2020

/retest

JoelSpeed
JoelSpeed reviewed Nov 18, 2020
View reviewed changes
docs/dev/metrics.md Outdated Show resolved Hide resolved
docs/dev/metrics.md Outdated Show resolved Hide resolved
pkg/metrics/machinehealthcheck.go Outdated Show resolved Hide resolved
@elmiko elmiko force-pushed the add-mhc-successful-remediations-metric branch from 08917b2 to 7784c28 Compare November 18, 2020 21:54
@elmiko
Copy link
Contributor Author

elmiko commented Nov 18, 2020

updated to add the namespace label and change the Register... func call to Observe...

JoelSpeed
JoelSpeed reviewed Nov 19, 2020
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@elmiko
Copy link
Contributor Author

elmiko commented Nov 19, 2020

/retest

1 similar comment
@elmiko
Copy link
Contributor Author

elmiko commented Nov 20, 2020

/retest

@elmiko
add mapi_machinehealthcheck_remediation_success_total metric
d77fee8 
This change add the metric as well as a helper function to increase the
count, and update the metric doc to reflect the new metric.
@elmiko elmiko force-pushed the add-mhc-successful-remediations-metric branch from 7784c28 to d77fee8 Compare November 20, 2020 19:32
@elmiko
Copy link
Contributor Author

elmiko commented Nov 20, 2020

/hold cancel
this is ready for review and merging now
it must go before #755

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2020
@elmiko
Copy link
Contributor Author

elmiko commented Nov 20, 2020

/retest

1 similar comment
@JoelSpeed
Copy link
Contributor

/retest

@Danil-Grigorev
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

@elmiko: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt d77fee8 link /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 83977d2 into openshift:master Nov 23, 2020
@elmiko elmiko deleted the add-mhc-successful-remediations-metric branch November 30, 2020 20:59
@elmiko elmiko mentioned this pull request Dec 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@cynepco3hahue cynepco3hahue Awaiting requested review from cynepco3hahue

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@Danil-Grigorev Danil-Grigorev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@elmiko @openshift-ci-robot @JoelSpeed @Danil-Grigorev @openshift-bot @openshift-merge-robot