Bug 1880787: Remove changes required to deploy metal3 pods from MAO #767

sadasu · 2020-11-30T21:13:31Z

cluster-baremetal-operator will take care of managing these
resources.

sadasu · 2020-12-01T01:55:11Z

/test e2e-aws

sadasu · 2020-12-01T14:21:18Z

/test e2e-metal-ipi

sadasu · 2020-12-01T16:55:01Z

/retest

stbenjam · 2020-12-01T18:18:18Z

What do you think about removing the RelatedObjects from status.go and status_test.go?

machine-api-operator/pkg/operator/status.go

Lines 203 to 207 in 71aeab4

    
           	Group:     "metal3.io", 
        
           	Resource:  "baremetalhosts", 
        
           	Name:      "", 
        
           	Namespace: optr.namespace, 
        
           },

machine-api-operator/pkg/operator/status_test.go

Lines 241 to 246 in 71aeab4

    
           { 
        
           	Group:     "metal3.io", 
        
           	Resource:  "baremetalhosts", 
        
           	Name:      "", 
        
           	Namespace: namespace, 
        
           },

stbenjam · 2020-12-01T19:00:11Z

/retitle Bug 1903275: Remove changes required to deploy metal3 pods from MAO

openshift-ci-robot · 2020-12-01T19:00:32Z

@sadasu: This pull request references Bugzilla bug 1903275, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1903275: Remove changes required to deploy metal3 pods from MAO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2020-12-01T19:01:35Z

Let's use this PR as the fix for the CRD conflict between CBO and MAO.

/bugzilla refresh

openshift-ci-robot · 2020-12-01T19:01:42Z

@stbenjam: This pull request references Bugzilla bug 1903275, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Let's use this PR as the fix for the CRD conflict between CBO and MAO.

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sadasu · 2020-12-01T19:24:49Z

#767 (comment)

@stbenjam I am not sure if we need that because capbm refers to the baremetalhost CR. I could try to make that change and test.

cluster-baremetal-operator will take care of managing these resources.

michaelgugino

/lgtm

stbenjam · 2020-12-01T20:49:19Z

#767 (comment)

@stbenjam I am not sure if we need that because capbm refers to the baremetalhost CR. I could try to make that change and test.

Oh I see, that makes sense, it probably should stay as a related object then.

sadasu · 2020-12-01T21:34:32Z

/test e2e-aws

stbenjam · 2020-12-01T21:47:53Z

/lgtm

@michaelgugino Would you be able to approve or do we need to get someone else? Thanks!

sadasu · 2020-12-02T00:52:21Z

/retest

openshift-ci-robot · 2020-12-02T12:34:57Z

@sadasu: This pull request references Bugzilla bug 1880787, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1880787: Remove changes required to deploy metal3 pods from MAO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2020-12-02T14:06:42Z

/approve

openshift-ci-robot · 2020-12-02T14:07:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-12-02T14:12:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-02T14:25:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sadasu · 2020-12-02T17:33:58Z

/retest

openshift-bot · 2020-12-02T18:32:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2020-12-02T19:25:14Z

Previous e2e-aws-operator job:

2020/12/02 14:06:29 Container test in pod e2e-aws-operator-test completed successfully

before getting hung up in a slow gather-extra step. If this is blocking promotions, maybe we should /override ci/prow/e2e-aws-operator instead of waiting for a retest to go through? Maybe only if this current job fails?

wking · 2020-12-02T19:25:32Z

/bugzilla refresh

to pick up the urgent tag.

openshift-ci-robot · 2020-12-02T19:25:37Z

@wking: This pull request references Bugzilla bug 1880787, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

to pick up the urgent tag.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-02T20:03:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2020-12-02T20:04:31Z

e2e-aws-operator failed install with VPC: VpcLimitExceeded, which is a CI-infra issue, orthogonal to this PR.

stbenjam · 2020-12-02T20:06:19Z

Overriding it sounds fine to us, we'll need an approver in MAO to actually do it: Maybe @JoelSpeed or @michaelgugino?

openshift-bot · 2020-12-02T20:42:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-02T22:00:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-02T22:13:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-02T23:05:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2020-12-02T23:36:40Z

Most recent e2e-aws-operator failure is:

Autoscaler should use a ClusterAutoscaler that has 12 maximum total nodes count and balance similar nodes enabled scales up and down while respecting MaxNodesTotal

But both install and gather-extra worked fine this time 😆

openshift-bot · 2020-12-03T05:09:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-03T05:22:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-12-03T06:50:49Z

@sadasu: All pull requests linked via external trackers have merged:

Bugzilla bug 1880787 has been moved to the MODIFIED state.

In response to this:

Bug 1880787: Remove changes required to deploy metal3 pods from MAO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from Danil-Grigorev and enxebre November 30, 2020 21:13

sadasu force-pushed the remove-baremetal branch from 6bf3486 to ec90a30 Compare November 30, 2020 21:43

openshift-ci-robot changed the title ~~Remove changes required to deploy metal3 pods from MAO~~ Bug 1903275: Remove changes required to deploy metal3 pods from MAO Dec 1, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 1, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 1, 2020

sadasu force-pushed the remove-baremetal branch from ec90a30 to 06283c2 Compare December 1, 2020 19:07

Remove changes required to deploy metal3 pods from MAO

c49ca7f

cluster-baremetal-operator will take care of managing these resources.

sadasu force-pushed the remove-baremetal branch from 06283c2 to c49ca7f Compare December 1, 2020 19:48

michaelgugino approved these changes Dec 1, 2020

View reviewed changes

openshift-ci-robot assigned michaelgugino Dec 1, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020

openshift-ci-robot assigned stbenjam Dec 1, 2020

openshift-ci-robot removed the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Dec 2, 2020

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Dec 2, 2020

andfasano mentioned this pull request Dec 2, 2020

Add missing ErrorCount field to BareMetalHost CRD #747

Closed

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020

elmiko mentioned this pull request Dec 2, 2020

Update RBAC to enable access to machineconfig object for the baremetal controller #766

Merged

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Dec 2, 2020

openshift-merge-robot merged commit 6e6c0cf into openshift:master Dec 3, 2020

hardys mentioned this pull request Dec 9, 2020

Change PROVISIONING_IP to an IP #712

Closed

Bug 1880787: Remove changes required to deploy metal3 pods from MAO #767

Bug 1880787: Remove changes required to deploy metal3 pods from MAO #767

Conversation

sadasu commented Nov 30, 2020

sadasu commented Dec 1, 2020

sadasu commented Dec 1, 2020

sadasu commented Dec 1, 2020

stbenjam commented Dec 1, 2020

stbenjam commented Dec 1, 2020

openshift-ci-robot commented Dec 1, 2020

stbenjam commented Dec 1, 2020

openshift-ci-robot commented Dec 1, 2020

sadasu commented Dec 1, 2020

michaelgugino left a comment

Choose a reason for hiding this comment

stbenjam commented Dec 1, 2020

sadasu commented Dec 1, 2020

stbenjam commented Dec 1, 2020

sadasu commented Dec 2, 2020

openshift-ci-robot commented Dec 2, 2020

JoelSpeed commented Dec 2, 2020

openshift-ci-robot commented Dec 2, 2020

openshift-bot commented Dec 2, 2020

openshift-bot commented Dec 2, 2020

sadasu commented Dec 2, 2020

openshift-bot commented Dec 2, 2020

wking commented Dec 2, 2020

wking commented Dec 2, 2020

openshift-ci-robot commented Dec 2, 2020

openshift-bot commented Dec 2, 2020

wking commented Dec 2, 2020

stbenjam commented Dec 2, 2020

openshift-bot commented Dec 2, 2020

openshift-bot commented Dec 2, 2020

openshift-bot commented Dec 2, 2020

openshift-bot commented Dec 2, 2020

wking commented Dec 2, 2020

openshift-bot commented Dec 3, 2020

openshift-bot commented Dec 3, 2020

openshift-ci-robot commented Dec 3, 2020