Bug 1903733: MachineSet: Prefer to delete non-Running machines during scale down #772

mdbooth · 2020-12-02T17:52:44Z

See: https://bugzilla.redhat.com/1903733

mandre · 2020-12-02T18:00:09Z

/retitle Bug 1903733: MachineSet: Prefer to delete non-Running machines during scale down

openshift-ci-robot · 2020-12-02T18:00:31Z

@mdbooth: This pull request references Bugzilla bug 1903733, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1903733: MachineSet: Prefer to delete non-Running machines during scale down

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre · 2020-12-02T18:02:18Z

/bugzilla refresh

openshift-ci-robot · 2020-12-02T18:02:24Z

@mandre: An error was encountered adding this pull request to the external tracker bugs for bug 1903733 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for the RPC call to Jira: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/machine-api-operator/pulls/772 Error: 403 Forbidden at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559eb5...', 'https://api.github.com/repos/openshift/machine-api-operator/p...', 'GET') called at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559eb5...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559eb5803208)') called at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559eb5803208)', 1) called at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x559eb57b7fc8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x559eb54019e8)', 'HASH(0x559eb57812f8)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x559eb57812f8)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x559eb5780500)') called at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559eb542afe0)') called at (eval 1941) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559eb542b178)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559eb542b178)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559eb542ad88)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x559eb54123b8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x559eb54123b8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559eb542ad88)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559eb542ad88)') called at (eval 1941) line 0 eval {...} called at (eval 1941) line 0 at /var/www/html/bugzilla/Bugzilla/Error.pm line 130. Bugzilla::Error::_throw_error('global/user-error.html.tmpl', 'ext_bz_rest_error', 'HASH(0x559eb5810578)') called at /var/www/html/bugzilla/Bugzilla/Error.pm line 193 Bugzilla::Error::ThrowUserError('ext_bz_rest_error', 'HASH(0x559eb5810578)') called at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 120 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559eb5...', 'https://api.github.com/repos/openshift/machine-api-operator/p...', 'GET') called at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559eb5...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559eb5803208)') called at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559eb5803208)', 1) called at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x559eb57b7fc8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x559eb54019e8)', 'HASH(0x559eb57812f8)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x559eb57812f8)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x559eb5780500)') called at /loader/0x559ea6ec1638/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559eb542afe0)') called at (eval 1941) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559eb542b178)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559eb542b178)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559eb542ad88)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x559eb54123b8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x559eb54123b8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559eb542ad88)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559eb542ad88)') called at (eval 1941) line 0 eval {...} called at (eval 1941) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mdbooth · 2020-12-03T09:37:47Z

/bugzilla refresh

openshift-ci-robot · 2020-12-03T09:37:54Z

@mdbooth: This pull request references Bugzilla bug 1903733, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2020-12-03T09:57:27Z

/test e2e-openstack

pierreprinetti · 2020-12-03T10:05:09Z

/retest
/label platform/openstack

openshift-ci-robot · 2020-12-03T10:05:10Z

@pierreprinetti: The label(s) platform/openstack cannot be applied, because the repository doesn't have them

In response to this:

/retest
/label platform/openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed

Do we need to update other deletion policies while we are here?

pkg/controller/machineset/delete_policy.go

mdbooth · 2020-12-03T10:49:30Z

@JoelSpeed I thought about updating the other 2 policies but decided not to because they're explicitly age based. I feel like if the user has explicitly opted in to 'newest' or 'oldest' then that's what they should get.

This is a design decision, though, and as I'm not a maintainer I'm more than happy to update the other policies if you'd prefer.

See: https://bugzilla.redhat.com/1903733

pierreprinetti · 2020-12-03T11:38:48Z

/test e2e-openstack

JoelSpeed · 2020-12-03T12:09:56Z

@JoelSpeed I thought about updating the other 2 policies but decided not to because they're explicitly age based. I feel like if the user has explicitly opted in to 'newest' or 'oldest' then that's what they should get.

Given how close we are to feature freeze, I think it's best not to push the boat too far, let's just fix the immediate bug, your decision and reasoning sounds good to me! I'll revisit this with the team during the 4.8 cycle

/approve

openshift-ci-robot · 2020-12-03T12:10:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mandre

/test e2e-openstack

mandre · 2020-12-06T10:22:39Z

/retest

JoelSpeed · 2020-12-08T10:11:52Z

/test e2e-openstack

mdbooth · 2020-12-08T10:29:56Z

If we're having CI reliability issues, note that there's nothing OpenStack specific in this patch. It's probably good enough that it has succeeded on any cloud provider, and I note that it has run successfully on AWS, Azure, and GCP.

Incidentally, do we have a scale down test?

Danil-Grigorev

/lgtm

openshift-bot · 2020-12-10T14:21:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-10T14:33:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-10T16:17:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-10T17:09:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-10T17:22:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot · 2020-12-10T18:41:24Z

@mdbooth: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere	`3ceba01`	link	`/test e2e-vsphere`
ci/prow/e2e-vsphere-operator	`3ceba01`	link	`/test e2e-vsphere-operator`
ci/prow/e2e-openstack	`3ceba01`	link	`/test e2e-openstack`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-12-10T19:58:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-12-10T20:32:28Z

@mdbooth: All pull requests linked via external trackers have merged:

openshift/machine-api-operator#772

Bugzilla bug 1903733 has been moved to the MODIFIED state.

In response to this:

Bug 1903733: MachineSet: Prefer to delete non-Running machines during scale down

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from enxebre and JoelSpeed December 2, 2020 17:53

openshift-ci-robot changed the title ~~MachineSet: Prefer to delete non-Running machines during scale down~~ Bug 1903733: MachineSet: Prefer to delete non-Running machines during scale down Dec 2, 2020

openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 2, 2020

JoelSpeed reviewed Dec 3, 2020

View reviewed changes

pkg/controller/machineset/delete_policy.go Outdated Show resolved Hide resolved

MachineSet: Prefer to delete non-Running machines during scale down

3ceba01

See: https://bugzilla.redhat.com/1903733

mdbooth force-pushed the bz1903733 branch from 97ccec2 to 3ceba01 Compare December 3, 2020 11:04

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020

mandre reviewed Dec 3, 2020

View reviewed changes

Danil-Grigorev reviewed Dec 10, 2020

View reviewed changes

openshift-ci-robot assigned Danil-Grigorev Dec 10, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020

openshift-merge-robot merged commit b57d987 into openshift:master Dec 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1903733: MachineSet: Prefer to delete non-Running machines during scale down #772

Bug 1903733: MachineSet: Prefer to delete non-Running machines during scale down #772

mdbooth commented Dec 2, 2020

mandre commented Dec 2, 2020

openshift-ci-robot commented Dec 2, 2020

mandre commented Dec 2, 2020

openshift-ci-robot commented Dec 2, 2020

mdbooth commented Dec 3, 2020

openshift-ci-robot commented Dec 3, 2020

pierreprinetti commented Dec 3, 2020

pierreprinetti commented Dec 3, 2020

openshift-ci-robot commented Dec 3, 2020

JoelSpeed left a comment

mdbooth commented Dec 3, 2020

pierreprinetti commented Dec 3, 2020

JoelSpeed commented Dec 3, 2020

openshift-ci-robot commented Dec 3, 2020

mandre left a comment

mandre commented Dec 6, 2020

JoelSpeed commented Dec 8, 2020

mdbooth commented Dec 8, 2020

Danil-Grigorev left a comment

openshift-bot commented Dec 10, 2020

openshift-bot commented Dec 10, 2020

openshift-bot commented Dec 10, 2020

openshift-bot commented Dec 10, 2020

openshift-bot commented Dec 10, 2020

openshift-merge-robot commented Dec 10, 2020

openshift-bot commented Dec 10, 2020

openshift-ci-robot commented Dec 10, 2020

Bug 1903733: MachineSet: Prefer to delete non-Running machines during scale down #772

Bug 1903733: MachineSet: Prefer to delete non-Running machines during scale down #772

Conversation

mdbooth commented Dec 2, 2020

mandre commented Dec 2, 2020

openshift-ci-robot commented Dec 2, 2020

mandre commented Dec 2, 2020

openshift-ci-robot commented Dec 2, 2020

mdbooth commented Dec 3, 2020

openshift-ci-robot commented Dec 3, 2020

pierreprinetti commented Dec 3, 2020

pierreprinetti commented Dec 3, 2020

openshift-ci-robot commented Dec 3, 2020

JoelSpeed left a comment

Choose a reason for hiding this comment

mdbooth commented Dec 3, 2020

pierreprinetti commented Dec 3, 2020

JoelSpeed commented Dec 3, 2020

openshift-ci-robot commented Dec 3, 2020

mandre left a comment

Choose a reason for hiding this comment

mandre commented Dec 6, 2020

JoelSpeed commented Dec 8, 2020

mdbooth commented Dec 8, 2020

Danil-Grigorev left a comment

Choose a reason for hiding this comment

openshift-bot commented Dec 10, 2020

openshift-bot commented Dec 10, 2020

openshift-bot commented Dec 10, 2020

openshift-bot commented Dec 10, 2020

openshift-bot commented Dec 10, 2020

openshift-merge-robot commented Dec 10, 2020

openshift-bot commented Dec 10, 2020

openshift-ci-robot commented Dec 10, 2020