Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove kubevirt images and references #873

Merged

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Jun 16, 2021

This change is being created to address the removal of these artifacts in
the 4.8 release. After this change has been backported to 4.8 it should
be reverted for the 4.9 branch.

ref: openshift-eng/ocp-build-data#944

This change is being created to address the removal of these artifacts in
the 4.8 release. After this change has been backported to 4.8 it should
be reverted for the 4.9 branch.

ref: openshift-eng/ocp-build-data#944
@vikaslaad
Copy link

lgtm, this is needed to remove image from 4.8 payload since its not shipping with 4.8

@elmiko
Copy link
Contributor Author

elmiko commented Jun 16, 2021

/cherry-pick release-4.8

@openshift-cherrypick-robot

@elmiko: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikaslaad
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@elmiko
Copy link
Contributor Author

elmiko commented Jun 16, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@elmiko
Copy link
Contributor Author

elmiko commented Jun 16, 2021

/test e2e-aws-upgrade

@elmiko
Copy link
Contributor Author

elmiko commented Jun 16, 2021

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@vikaslaad
Copy link

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

elmiko added a commit to elmiko/machine-api-operator that referenced this pull request Jun 17, 2021
This change re-adds the kubevirt images and tests to the
machine-api-operator. They were removed to enable a backport to the 4.8
release branch, in which those images were not shipped. This changeset
sets things back to the status quo.

ref: openshift#873
@elmiko elmiko mentioned this pull request Jun 17, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

@elmiko: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-disruptive 38becfa link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@JoelSpeed
Copy link
Contributor

Do we need to merge this into master or can we skip some of the automation and prioritise this by merging straight into 4.8, as we want this in 4.9 anyway right?

@openshift-cherrypick-robot

@elmiko: new pull request created: #876

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elmiko added a commit to elmiko/machine-api-operator that referenced this pull request Jun 17, 2021
This change re-adds the kubevirt images and tests to the
machine-api-operator. They were removed to enable a backport to the 4.8
release branch, in which those images were not shipped. This changeset
sets things back to the status quo.

ref: openshift#873
@elmiko elmiko deleted the remove-kubevirt-images branch June 17, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants