New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1974758: install/0000_90_machine-api-operator_04_alertrules: Use '!~' for MachineWithNoRunningPhase #878
Bug 1974758: install/0000_90_machine-api-operator_04_alertrules: Use '!~' for MachineWithNoRunningPhase #878
Conversation
…ineWithNoRunningPhase b13dbe9 (add alert for machine with long deletion phase, 2021-02-22, openshift#807) added "|Deleting". But to move from "not equal" to "regexp does not match" we need to match that with !~.
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retitle Bug 1974758: install/0000_90_machine-api-operator_04_alertrules: Use '!~' for MachineWithNoRunningPhase |
@wking: Bugzilla bug 1974758 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Seems worth bringing this to 4.7 as well /cherry-pick release-4.7 |
@vrutkovs: #878 failed to apply on top of branch "release-4.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b13dbe9 (#807) added
|Deleting
. But to move from "not equal" to "regexp does not match" we need to match that with!~
./assign @elmiko