Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1974758: install/0000_90_machine-api-operator_04_alertrules: Use '!~' for MachineWithNoRunningPhase #878

Conversation

wking
Copy link
Member

@wking wking commented Jun 22, 2021

b13dbe9 (#807) added |Deleting. But to move from "not equal" to "regexp does not match" we need to match that with !~.

/assign @elmiko

…ineWithNoRunningPhase

b13dbe9 (add alert for machine with long deletion phase,
2021-02-22, openshift#807) added "|Deleting".  But to move from "not equal" to
"regexp does not match" we need to match that with !~.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 9393c0f link /test e2e-libvirt
ci/prow/e2e-gcp 9393c0f link /test e2e-gcp
ci/prow/e2e-gcp-operator 9393c0f link /test e2e-gcp-operator
ci/prow/e2e-metal-ipi-ovn-ipv6 9393c0f link /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-upgrade 9393c0f link /test e2e-vsphere-upgrade
ci/prow/e2e-aws-disruptive 9393c0f link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2021
@lobziik
Copy link
Contributor

lobziik commented Jun 22, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@openshift-merge-robot openshift-merge-robot merged commit a44b24b into openshift:master Jun 22, 2021
@wking wking deleted the MachineWithNoRunningPhase-not-regexp-fix branch June 22, 2021 14:24
@elmiko
Copy link
Contributor

elmiko commented Jun 22, 2021

/retitle Bug 1974758: install/0000_90_machine-api-operator_04_alertrules: Use '!~' for MachineWithNoRunningPhase

@openshift-ci openshift-ci bot changed the title install/0000_90_machine-api-operator_04_alertrules: Use '!~' for MachineWithNoRunningPhase Bug 1974758: install/0000_90_machine-api-operator_04_alertrules: Use '!~' for MachineWithNoRunningPhase Jun 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

@wking: Bugzilla bug 1974758 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Bug 1974758: install/0000_90_machine-api-operator_04_alertrules: Use '!~' for MachineWithNoRunningPhase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Member

Seems worth bringing this to 4.7 as well

/cherry-pick release-4.7

@openshift-cherrypick-robot

@vrutkovs: #878 failed to apply on top of branch "release-4.7":

Applying: install/0000_90_machine-api-operator_04_alertrules: Use '!~' for MachineWithNoRunningPhase
Using index info to reconstruct a base tree...
M	install/0000_90_machine-api-operator_04_alertrules.yaml
Falling back to patching base and 3-way merge...
Auto-merging install/0000_90_machine-api-operator_04_alertrules.yaml
CONFLICT (content): Merge conflict in install/0000_90_machine-api-operator_04_alertrules.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 install/0000_90_machine-api-operator_04_alertrules: Use '!~' for MachineWithNoRunningPhase
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Seems worth bringing this to 4.7 as well

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants