Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1980930: Update the default durations for MAO leader election operations #890

Merged
merged 1 commit into from Jul 29, 2021

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Jul 16, 2021

According to [1] to successfully handle kube-apiserver disruption we need to updated default durations for MAO leader election operations.

New values are LeaseDuration=137s, RenewDealine=107s, RetryPeriod=26s.

[1] openshift/enhancements#832

@openshift-ci openshift-ci bot requested review from elmiko and enxebre July 16, 2021 14:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2021

@Fedosin: This pull request references Bugzilla bug 1980930, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 1980930: Update the default durations for MAO leader election operations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 16, 2021
@openshift-ci openshift-ci bot requested a review from sunzhaohua2 July 16, 2021 14:36
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what these helpers are used for, but it looks like this PR doesn't functionally change anything right now?

Looking at cmd/machine-healthcheck/main.go, it seems the values used there are defined in the same file on lines 24-26, which have not yet been updated. Could you please make sure we are either using a consistent set of vars everywhere or update across all locations please

@Fedosin
Copy link
Contributor Author

Fedosin commented Jul 21, 2021

@JoelSpeed should be it now :)

@Fedosin
Copy link
Contributor Author

Fedosin commented Jul 21, 2021

/test e2e-aws-operator

Comment on lines 24 to 26
leaseDuration = 137 * time.Second
renewDealine = 107 * time.Second
retryPeriod = 26 * time.Second
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to import the values from the helpers package here?

Suggested change
leaseDuration = 137 * time.Second
renewDealine = 107 * time.Second
retryPeriod = 26 * time.Second
leaseDuration = helpers.LeaseDuration
renewDealine = helpers.RenewDeadline
retryPeriod = helpers.RetryPeriod

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we have to import "github.com/openshift/machine-api-operator/cmd/machinea-api-operator", I don't think it's a good practice.
It would be better to create a file in pkg/utils and use it everywhere.

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @Fedosin

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
…rations

According to [1] to successfully handle kube-apiserver disruption
we need to updated default durations for MAO leader election
operations.

New values are LeaseDuration=137s, RenewDealine=107s, RetryPeriod=26s.

[1] openshift/enhancements#832
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021
@Fedosin
Copy link
Contributor Author

Fedosin commented Jul 29, 2021

/test e2e-aws-upgrade

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice, thanks Mike
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

@Fedosin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 51d1876 link /test e2e-libvirt
ci/prow/e2e-vsphere 51d1876 link /test e2e-vsphere
ci/prow/e2e-vsphere-upgrade 51d1876 link /test e2e-vsphere-upgrade
ci/prow/e2e-gcp 51d1876 link /test e2e-gcp
ci/prow/e2e-azure-operator 51d1876 link /test e2e-azure-operator
ci/prow/e2e-gcp-operator 51d1876 link /test e2e-gcp-operator
ci/prow/e2e-aws-disruptive 51d1876 link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Fedosin
Copy link
Contributor Author

Fedosin commented Jul 29, 2021

/test e2e-aws-operator

@openshift-merge-robot openshift-merge-robot merged commit edaf826 into openshift:master Jul 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

@Fedosin: All pull requests linked via external trackers have merged:

Bugzilla bug 1980930 has been moved to the MODIFIED state.

In response to this:

Bug 1980930: Update the default durations for MAO leader election operations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants