New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1980930: Update the default durations for MAO leader election operations #890
Conversation
@Fedosin: This pull request references Bugzilla bug 1980930, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what these helpers are used for, but it looks like this PR doesn't functionally change anything right now?
Looking at cmd/machine-healthcheck/main.go, it seems the values used there are defined in the same file on lines 24-26, which have not yet been updated. Could you please make sure we are either using a consistent set of vars everywhere or update across all locations please
@JoelSpeed should be it now :) |
/test e2e-aws-operator |
cmd/machine-healthcheck/main.go
Outdated
leaseDuration = 137 * time.Second | ||
renewDealine = 107 * time.Second | ||
retryPeriod = 26 * time.Second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to import the values from the helpers package here?
leaseDuration = 137 * time.Second | |
renewDealine = 107 * time.Second | |
retryPeriod = 26 * time.Second | |
leaseDuration = helpers.LeaseDuration | |
renewDealine = helpers.RenewDeadline | |
retryPeriod = helpers.RetryPeriod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case we have to import "github.com/openshift/machine-api-operator/cmd/machinea-api-operator", I don't think it's a good practice.
It would be better to create a file in pkg/utils and use it everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @Fedosin
…rations According to [1] to successfully handle kube-apiserver disruption we need to updated default durations for MAO leader election operations. New values are LeaseDuration=137s, RenewDealine=107s, RetryPeriod=26s. [1] openshift/enhancements#832
/lgtm |
/test e2e-aws-upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice, thanks Mike
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Fedosin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-aws-operator |
@Fedosin: All pull requests linked via external trackers have merged: Bugzilla bug 1980930 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
According to [1] to successfully handle kube-apiserver disruption we need to updated default durations for MAO leader election operations.
New values are LeaseDuration=137s, RenewDealine=107s, RetryPeriod=26s.
[1] openshift/enhancements#832