Bug 1988032: add cvo ha annotations to tombstones #893
Conversation
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@elmiko: This pull request references Bugzilla bug 1988032, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
/retest-required |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm cancel This PR still has some syntax issue by the looks of things, CVO is broken by this |
|
that's a really odd message, i'll do some digging |
elmiko
force-pushed
the
update-tombstones
branch
from
c866aea
to
a1811dc
Compare
|
think i found it, looks like i had the wrong api version, see https://github.com/openshift/machine-api-operator/blob/release-4.1/install/0000_30_machine-api-operator_00_credentials-request.yaml#L1 |
|
hmm, looks like still a couple syntax errors. |
elmiko
force-pushed
the
update-tombstones
branch
from
a1811dc
to
ad92e46
Compare
|
update the |
This change adds the annotation `include.release.openshift.io/self-managed-high-availability: "true"` to the tombstones. This is needed to ensure that the CVO will process them.
elmiko
force-pushed
the
update-tombstones
branch
from
ad92e46
to
af2f3bd
Compare
|
changed CRD versions to use |
|
/test e2e-aws-upgrade @JoelSpeed i think we've got the syntax errors nailed down |
|
/test e2e-aws-upgrade |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
13 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@elmiko: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@elmiko: All pull requests linked via external trackers have merged: Bugzilla bug 1988032 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Since these manifests took effect in af2f3bd (add cvo ha annotations to tombstones, 2021-07-29, openshift#893, OpenShift 4.9), the only change has been d3a5a0e (add capability annotation, 2023-02-14, 4.8 cluster that might have included these resources should have completed an update to 4.9 which would have removed them. And if that failed, they should have completed an update to one of the later 4.y and removed the resources. By removing the resource, we save the cluster-version operator some time checking to ensure deletion, and only expose ourselves to leaking the resources on clusters that updated from 4.8 through to 4.14 without ever having completed an update before reaching 4.14.
Since these manifests took effect in af2f3bd (add cvo ha annotations to tombstones, 2021-07-29, openshift#893, OpenShift 4.9), the only change has been d3a5a0e (add capability annotation, 2023-02-14, openshift#1119). We can remove these deletion references now, because a 4.8 cluster that might have included these resources should have completed an update to 4.9 which would have removed them. And if that failed, they should have completed an update to one of the later 4.y and removed the resources. By removing the resource, we save the cluster-version operator some time checking to ensure deletion, and only expose ourselves to leaking the resources on clusters that updated from 4.8 through to 4.14 without ever having completed an update before reaching 4.14.
This change adds the annotation
include.release.openshift.io/self-managed-high-availability: "true"to the tombstones. This is needed to ensure that the CVO will process
them.