[release-4.6] [OCPCLOUD-1222] Bug 1993120: Make sure nodes don't have attached volumes before vm deletion #905

openshift-cherrypick-robot · 2021-08-12T12:23:15Z

This is an automated cherry-pick of #894

/assign Fedosin

…letion This commit checks if the node has some attached volumes before deleting its vm. If there are any, it doesn't allow to delete the vm and returns an error.

openshift-ci · 2021-08-12T12:23:30Z

@openshift-cherrypick-robot: Bugzilla bug 1990432 has been cloned as Bugzilla bug 1993120. Retitling PR to link against new bug.
/retitle [release-4.6] [OCPCLOUD-1222] Bug 1993120: Make sure nodes don't have attached volumes before vm deletion

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-12T12:23:35Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1990432 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
expected dependent Bugzilla bug 1990432 to target a release in 4.7.0, 4.7.z, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2021-08-16T10:39:02Z

/bugzilla refresh

openshift-ci · 2021-08-16T10:39:06Z

@JoelSpeed: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1990432 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
expected dependent Bugzilla bug 1990432 to target a release in 4.7.0, 4.7.z, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2021-08-16T10:41:23Z

/bugzilla refresh

openshift-ci · 2021-08-16T10:41:26Z

@JoelSpeed: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2021-08-19T09:40:08Z

This bug has the potential to cause data loss if a customer is using persistent volumes on a Machine when the Machine is being removed. Because of this we believe this is warranted for a backport to 4.6.

/approve
/lgtm

openshift-ci · 2021-08-19T09:40:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-08-20T01:00:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-20T01:00:18Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-21T01:00:59Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-21T01:01:22Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-22T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-22T01:01:02Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-23T01:00:54Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-23T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-24T01:01:25Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-24T01:01:30Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-25T01:00:20Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-bot · 2021-10-10T01:01:20Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-10T01:01:23Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-11T01:00:48Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-11T01:00:52Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-12T01:00:52Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-12T01:00:56Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-13T01:01:12Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-13T01:01:16Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-14T01:01:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-14T01:01:23Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-15T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-15T01:01:12Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-16T01:00:37Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-16T01:00:40Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-17T01:00:45Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-17T01:00:48Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-18T01:00:42Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-18T01:00:46Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-19T01:00:46Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-19T01:00:49Z

@openshift-bot: This pull request references Bugzilla bug 1993120, which is invalid:

expected dependent Bugzilla bug 1993118 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2021-10-19T16:38:04Z

/bugzilla refresh

openshift-ci · 2021-10-19T16:38:10Z

@JoelSpeed: This pull request references Bugzilla bug 1993120, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1993118 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1993118 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

Requesting review from QA contact:
/cc @miyadav

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2021-10-19T16:41:44Z

We've had a lot of discussion regarding this PR and whether it should be backported to 4.6 or not. As 4.6 is an EUS and the consequences of this bug (data loss) are pretty major, we still believe this is worth backporting

/label backport-risk-assessed

openshift-ci · 2021-10-20T01:49:57Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/machine-api-operator#905

Bugzilla bug 1993120 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 1990432: Make sure nodes don't have attached volumes before vm de…

29726c1

…letion This commit checks if the node has some attached volumes before deleting its vm. If there are any, it doesn't allow to delete the vm and returns an error.

openshift-ci bot assigned Fedosin Aug 12, 2021

openshift-cherrypick-robot mentioned this pull request Aug 12, 2021

[OCPCLOUD-1222] Bug 1990432: Make sure nodes don't have attached volumes before vm deletion #894

Merged

openshift-ci bot changed the title ~~[release-4.6] [OCPCLOUD-1222] Bug 1990432: Make sure nodes don't have attached volumes before vm deletion~~ [release-4.6] [OCPCLOUD-1222] Bug 1993120: Make sure nodes don't have attached volumes before vm deletion Aug 12, 2021

openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 12, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 12, 2021

openshift-ci bot requested review from elmiko and enxebre August 12, 2021 12:23

openshift-ci bot assigned JoelSpeed Aug 19, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 19, 2021

openshift-ci bot requested a review from miyadav October 19, 2021 16:38

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 19, 2021

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 20, 2021

openshift-merge-robot merged commit f049bea into openshift:release-4.6 Oct 20, 2021

[release-4.6] [OCPCLOUD-1222] Bug 1993120: Make sure nodes don't have attached volumes before vm deletion #905

[release-4.6] [OCPCLOUD-1222] Bug 1993120: Make sure nodes don't have attached volumes before vm deletion #905

Conversation

openshift-cherrypick-robot commented Aug 12, 2021

openshift-ci bot commented Aug 12, 2021

openshift-ci bot commented Aug 12, 2021

JoelSpeed commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

JoelSpeed commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

JoelSpeed commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021

openshift-bot commented Aug 20, 2021

openshift-ci bot commented Aug 20, 2021

openshift-bot commented Aug 21, 2021

openshift-ci bot commented Aug 21, 2021

openshift-bot commented Aug 22, 2021

openshift-ci bot commented Aug 22, 2021

openshift-bot commented Aug 23, 2021

openshift-ci bot commented Aug 23, 2021

openshift-bot commented Aug 24, 2021

openshift-ci bot commented Aug 24, 2021

openshift-bot commented Aug 25, 2021

openshift-bot commented Oct 10, 2021

openshift-ci bot commented Oct 10, 2021

openshift-bot commented Oct 11, 2021

openshift-ci bot commented Oct 11, 2021

openshift-bot commented Oct 12, 2021

openshift-ci bot commented Oct 12, 2021

openshift-bot commented Oct 13, 2021

openshift-ci bot commented Oct 13, 2021

openshift-bot commented Oct 14, 2021

openshift-ci bot commented Oct 14, 2021

openshift-bot commented Oct 15, 2021

openshift-ci bot commented Oct 15, 2021

openshift-bot commented Oct 16, 2021

openshift-ci bot commented Oct 16, 2021

openshift-bot commented Oct 17, 2021

openshift-ci bot commented Oct 17, 2021

openshift-bot commented Oct 18, 2021

openshift-ci bot commented Oct 18, 2021

openshift-bot commented Oct 19, 2021

openshift-ci bot commented Oct 19, 2021

JoelSpeed commented Oct 19, 2021

openshift-ci bot commented Oct 19, 2021

JoelSpeed commented Oct 19, 2021

openshift-ci bot commented Oct 20, 2021