Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreleased AWS Placement Groups support #35

Merged
merged 4 commits into from May 3, 2022
Merged

Remove unreleased AWS Placement Groups support #35

merged 4 commits into from May 3, 2022

Conversation

damdo
Copy link
Member

@damdo damdo commented Apr 28, 2022 •
edited

AWS Placement Groups support won't be landing in the coming release yet. As such we've updated openshift/api in openshift/api#1183 to remove the types related to the feature and in openshift/machine-api-operator#1009 to remove the CRD install & credentials requesting.

TODO:

Notes:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2022
@damdo damdo force-pushed the revert-aws-placement-groups branch from 7712c0c to 1740812 Compare April 28, 2022 10:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from elmiko and JoelSpeed April 28, 2022 10:50
elmiko
elmiko reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally makes sense to me
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 28, 2022
@damdo damdo mentioned this pull request Apr 29, 2022
Merged
@damdo damdo force-pushed the revert-aws-placement-groups branch from 036655c to 1740812 Compare April 29, 2022 13:31
@damdo damdo marked this pull request as ready for review April 29, 2022 13:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2022
@damdo damdo force-pushed the revert-aws-placement-groups branch 2 times, most recently from cc1839c to 7eae30f Compare May 3, 2022 11:03
JoelSpeed
JoelSpeed reviewed May 3, 2022
View reviewed changes
api/types_alibabaprovider.go Outdated Show resolved Hide resolved
pkg/actuators/awsplacementgroup/controller.go Outdated Show resolved Hide resolved
pkg/actuators/awsplacementgroup/controller_suite_test.go Outdated Show resolved Hide resolved
pkg/actuators/awsplacementgroup/controller_test.go Outdated Show resolved Hide resolved
damdo added 4 commits May 3, 2022 14:15
@damdo
awsplacementgroup: revert instance placement logic
070b027 
but keep machinev1 scheme install and runtimeclient/awsclient renamings
for future re-introductions/extensions.
@damdo
add openshift/api@5308d3d under api/
7a55137 
we snapshot a copy of github.com/openshift/api/machine/v1/ from commit 5308d3d
locally to have access to the "still experimental" awsplacementgroup
type and CRD, which has now been removed from openshift/api until the
API has been discussed also upstream.

Also disable go linting checks for these.
@damdo
awsplacementgroup: update type reference to point locally
f633e85
@damdo
bump openshift/api
f338ee9
@damdo damdo force-pushed the revert-aws-placement-groups branch from 7eae30f to f338ee9 Compare May 3, 2022 13:37
@damdo
Copy link
Member Author

damdo commented May 3, 2022

/test unit

1 similar comment
@damdo
Copy link
Member Author

damdo commented May 3, 2022

/test unit

@damdo
Copy link
Member Author

damdo commented May 3, 2022

/retest-required

elmiko
elmiko reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this continues to make sense for me, bringing the api type inside this repo seems like a nice upgrade too.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2022
JoelSpeed
JoelSpeed reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2022
@damdo
Copy link
Member Author

damdo commented May 3, 2022

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2022

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d7fdd03 into openshift:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

@elmiko elmiko

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@damdo @elmiko @JoelSpeed @openshift-merge-robot