OCPBUGS-2123: Fix availability sets unwanted creation for unknown vmSizes

[lobziik]

Currently, the availability zones service can not determine zones presence in case if incorrect vmSize was passed.
This PR introduces special handling for empty vmSize argument within the availability zones service. In case vmSize is an empty string, the service will try to determine AZs presence within the region.

[openshift-ci-robot]

@lobziik: This pull request references Jira Issue OCPBUGS-2123, which is invalid:

• expected the bug to target the "4.11.z" version, but no target version was set
• expected Jira Issue OCPBUGS-2123 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Currently, the availability zones service can not determine zones presence in case if incorrect vmSize was passed.
This PR introduces special handling for empty vmSize argument within the availability zones service. In case vmSize is an empty string, the service will try to determine AZs presence within the region.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@lobziik: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-2123: Fix availability sets unwanted creation for unknown vmSizes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

This fix is interesting, can we get this pre-merge verified please?

/lgtm

[openshift-ci]

@lobziik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-upgrade	9521f9f	link	false	/test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[lobziik]

/jira refresh

[openshift-ci-robot]

@lobziik: This pull request references Jira Issue OCPBUGS-2123, which is invalid:

• expected the bug to target the "4.11.z" version, but no target version was set
• expected dependent Jira Issue OCPBUGS-4911 to target a version in 4.12.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lobziik]

/jira refresh

[openshift-ci-robot]

@lobziik: This pull request references Jira Issue OCPBUGS-2123, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.11.z) matches configured target version for branch (4.11.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-4911 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-4911 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
• bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[huali9]

/label qe-approved

[JoelSpeed]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/label backport-risk-assessed

[sunzhaohua2]

/label cherry-pick-approved

[openshift-ci-robot]

@lobziik: All pull requests linked via external trackers have merged:

• openshift/machine-api-provider-azure#41

Jira Issue OCPBUGS-2123 has been moved to the MODIFIED state.

In response to this:

Currently, the availability zones service can not determine zones presence in case if incorrect vmSize was passed.
This PR introduces special handling for empty vmSize argument within the availability zones service. In case vmSize is an empty string, the service will try to determine AZs presence within the region.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.