Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPCLOUD-2057: Bump to Kubernetes 1.27 deps #62

Merged
merged 2 commits into from Jun 6, 2023
Merged

OCPCLOUD-2057: Bump to Kubernetes 1.27 deps #62

merged 2 commits into from Jun 6, 2023

Conversation

nrb
Copy link
Contributor

@nrb nrb commented May 17, 2023

Requires MAO's update to go through, and possibly a full v0.15.0 release from controller-runtime.

@nrb
Copy link
Contributor Author

nrb commented May 22, 2023

/retest

1 similar comment
@damdo
Copy link
Member

damdo commented May 23, 2023

/retest

@JoelSpeed
Copy link
Contributor 

E0523 08:09:28.427364   16156 machine_scope.go:222] Failed to patch machine "azure-actuator-testing-machine": machines.machine.openshift.io "azure-actuator-testing-machine" not found

This symptom in the tests is likely a side effect of updating controller-runtime, we use the status subresource, so you'll need to set up the fake client to understand which types have a status subresource, eg WithStatusSubresource(&machinev1.Machine{})

@odvarkadaniel
Copy link
Contributor

odvarkadaniel commented May 23, 2023 •
edited

Hi @nrb, could you please also include bumps of sigs.k8s.io/kustomize/api and sigs.k8s.io/kustomize/kyaml to latest version. There shouldn't be any problems with that. It solves https://issues.redhat.com/browse/OCPBUGS-5724 and I thought it would be easier for you to do it here, other than resolving conflicts between our 2 PRs.

@nrb
Copy link
Contributor Author

nrb commented May 24, 2023

@odvarkadaniel Sure thing, will include.

damdo
damdo reviewed May 24, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@nrb nrb force-pushed the 127-update branch 2 times, most recently from 6fc3c67 to c4611df Compare May 26, 2023 15:23
nrb added 2 commits May 26, 2023 17:22
@nrb
OCPCLOUD-2057: Bump to Kubernetes 1.27 deps
ff46fd0 
* Update fake clients for new controller-runtime methods.

Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@nrb
OCPBUGS-5724: Update kustomize libraries
78ebdc0 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@damdo
Copy link
Member

damdo commented May 27, 2023

/retest

@JoelSpeed
Copy link
Contributor

/retest-required

1 similar comment
@damdo
Copy link
Member

damdo commented May 30, 2023

/retest-required

@JoelSpeed
Copy link
Contributor

/retest

1 similar comment
@nrb
Copy link
Contributor Author

nrb commented May 31, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2023

@nrb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nrb
Copy link
Contributor Author

nrb commented Jun 1, 2023

/jira refresh

@openshift-ci-robot
Copy link

@nrb: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nrb nrb changed the title [OCPCLOUD-2057] Bump to Kubernetes 1.27 deps OCPCLOUD-2057: Bump to Kubernetes 1.27 deps Jun 1, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2023 •
edited by openshift-ci bot

@nrb: This pull request references OCPCLOUD-2057 which is a valid jira issue.

In response to this:

Requires MAO's update to go through, and possibly a full v0.15.0 release from controller-runtime.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 1, 2023
@nrb
Copy link
Contributor Author

nrb commented Jun 1, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2023 •
edited by openshift-ci bot

@nrb: This pull request references OCPCLOUD-2057 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

damdo
damdo reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
JoelSpeed
JoelSpeed reviewed Jun 1, 2023
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023
@sunzhaohua2
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 1, 2023
@dgoodwin
Copy link

dgoodwin commented Jun 6, 2023

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 83b07d5 into openshift:main Jun 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@odvarkadaniel odvarkadaniel Awaiting requested review from odvarkadaniel

Assignees

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@nrb @damdo @JoelSpeed @odvarkadaniel @openshift-ci-robot @sunzhaohua2 @dgoodwin @openshift-merge-robot