OCPBUGS-25940: Don't create availability set when using spot instances

[RadekManak]

When we are on region without availability zones, we create availability sets for machinesets. This causes machines when using spot instances, because spot instances do not support availability sets.

This PR disables implicit availability set creation when using spot instances.

[openshift-ci-robot]

@RadekManak: This pull request references Jira Issue OCPBUGS-25940, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When we are on region without availability zones, we create availability sets for machinesets. This causes machines when using spot instances, because spot instances do not support availability sets.

This PR disables implicit availability set creation when using spot instances.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

Are there any tests we can add to make sure we don't regress on this?

Is there an upstream issue/fix in flight for this within CAPZ?

[RadekManak]

/jira refresh

[openshift-ci-robot]

@RadekManak: This pull request references Jira Issue OCPBUGS-25940, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@RadekManak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-upgrade	503e6e5	link	false	/test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sunzhaohua2]

/label qe-approved

[openshift-ci-robot]

@RadekManak: This pull request references Jira Issue OCPBUGS-25940, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

When we are on region without availability zones, we create availability sets for machinesets. This causes machines when using spot instances, because spot instances do not support availability sets.

This PR disables implicit availability set creation when using spot instances.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

/approve
/lgtm
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@RadekManak: Jira Issue OCPBUGS-25940: Some pull requests linked via external trackers have merged:

• openshift/machine-api-provider-azure#91

The following pull requests linked via external trackers have not merged:

• openshift/cluster-api-actuator-pkg#307 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-25940 has not been moved to the MODIFIED state.

In response to this:

When we are on region without availability zones, we create availability sets for machinesets. This causes machines when using spot instances, because spot instances do not support availability sets.

This PR disables implicit availability set creation when using spot instances.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-api-provider-azure-container-v4.16.0-202402011710.p0.gb817ad0.assembly.stream for distgit ose-machine-api-provider-azure.
All builds following this will include this PR.

[RadekManak]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@RadekManak: new pull request created: #95

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.