OCPBUGS-28745: Improving performance of VMs created in Azure

[JoelSpeed]

Manual backport of #87/#93

---

This will enable us to change the number of concurrent reconciles so that we can test the behaviour of the controller when we increase the number of reconciles from the default value of 1.

It also ensures that we set the networkAddresses and providerID fields in the status when the VM is created, rather than waiting for the next reconcile to update these. This is important because the network addresses not being set causes the CSR approver not to work, which, when scaling up in large quantities, can cause a backlog which eventually prevents any CSRs being approved. This change should mitigate those slow approvals.

[openshift-ci-robot]

@JoelSpeed: This pull request references Jira Issue OCPBUGS-28745, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.z) matches configured target version for branch (4.14.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-27758 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-27758 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
• bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual backport of #87/#93

---

This will enable us to change the number of concurrent reconciles so that we can test the behaviour of the controller when we increase the number of reconciles from the default value of 1.

It also ensures that we set the networkAddresses and providerID fields in the status when the VM is created, rather than waiting for the next reconcile to update these. This is important because the network addresses not being set causes the CSR approver not to work, which, when scaling up in large quantities, can cause a backlog which eventually prevents any CSRs being approved. This change should mitigate those slow approvals.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[nrb]

/lgtm

[JoelSpeed]

/approve
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sunzhaohua2]

/label cherry-pick-approved

[openshift-ci-robot]

@JoelSpeed: Jira Issue OCPBUGS-28745: Some pull requests linked via external trackers have merged:

• openshift/machine-api-operator#1214

The following pull requests linked via external trackers have not merged:

• openshift/machine-api-operator#1217 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-28745 has not been moved to the MODIFIED state.

In response to this:

Manual backport of #87/#93

---

This will enable us to change the number of concurrent reconciles so that we can test the behaviour of the controller when we increase the number of reconciles from the default value of 1.

It also ensures that we set the networkAddresses and providerID fields in the status when the VM is created, rather than waiting for the next reconcile to update these. This is important because the network addresses not being set causes the CSR approver not to work, which, when scaling up in large quantities, can cause a backlog which eventually prevents any CSRs being approved. This change should mitigate those slow approvals.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-api-provider-azure-container-v4.14.0-202402070309.p0.g68dba89.assembly.stream.el8 for distgit ose-machine-api-provider-azure.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2024-02-16-015828