Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-28309: add an extra vendor exclude to snyk config #99

Merged
merged 1 commit into from Feb 29, 2024

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Feb 15, 2024

this change is being added because the snyk scanning appears to pickup a vendor folder during the cachito expansion.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 15, 2024
@openshift-ci-robot
Copy link

@elmiko: This pull request references Jira Issue OCPBUGS-28309, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

this change is being added because the snyk scanning appears to pickup a vendor folder during the cachito expansion.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 15, 2024
@nrb
Copy link
Contributor

nrb commented Feb 15, 2024

/retitle OCPBUGS-28309: add an extra vendor exclude to snyk config

@openshift-ci openshift-ci bot changed the title OCPBUGS-28309: add an extra vendor exclude to sny config OCPBUGS-28309: add an extra vendor exclude to snyk config Feb 15, 2024
this change is being added because the snyk scanning appears to pickup a
vendor folder during the cachito expansion.
@nrb
Copy link
Contributor

nrb commented Feb 28, 2024

/retest

@nrb
Copy link
Contributor

nrb commented Feb 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

@elmiko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dded9f7 into openshift:main Feb 29, 2024
10 checks passed
@openshift-ci-robot
Copy link

@elmiko: Jira Issue OCPBUGS-28309: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28309 has been moved to the MODIFIED state.

In response to this:

this change is being added because the snyk scanning appears to pickup a vendor folder during the cachito expansion.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-api-provider-azure-container-v4.16.0-202402291846.p0.gdded9f7.assembly.stream.el9 for distgit ose-machine-api-provider-azure.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants