Skip to content

Commit

Permalink
fix: run tests natively by default
Browse files Browse the repository at this point in the history
Tests like lint and vet used to be ran within a container engine by
default if an engine was detected, both locally and in CI.

Up until now no container engine was detected in CI, so tests would run natively there.

Now that the base image we use in CI has now started
shipping `podman`, a container engine is detected by default and tests
are run within podman by default. But creating nested containers doesn't
work in CI at the moment and thus results in a test failure.

As such we are switching the default behaviour for tests (both locally
and in CI), where now by
default no container engine is used to run tests, even if one is
detected, but instead tests are run natively unless otherwise specified.
  • Loading branch information
damdo committed Aug 30, 2023
1 parent ebfce99 commit 53ddff8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export GOFLAGS
GOPROXY ?=
export GOPROXY

NO_DOCKER ?= 0
NO_DOCKER ?= 1

ifeq ($(shell command -v podman > /dev/null 2>&1 ; echo $$? ), 0)
ENGINE=podman
Expand Down

0 comments on commit 53ddff8

Please sign in to comment.