Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-4504: refactor restartPolicyToBool function #26

Closed
wants to merge 1 commit into from
Closed

[release-4.12] OCPBUGS-4504: refactor restartPolicyToBool function #26

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #21

/assign elmiko

@elmiko
refactor restartPolicyToBool function
1e8fa3b 
to be more thorough about checking for empty string and preemptible
instances. previously this function only checked if the value was equal
to "Always". but, this misses the default omission case where we should
be defaulting to always restart but weren't. additionally, errors have
been added when the policy is not recognized or the user attempts to set
an always restart policy for a preemptible instance.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 5, 2022
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-1557 has been cloned as Jira Issue OCPBUGS-4504. Retitling PR to link against new bug.
/retitle [release-4.12] OCPBUGS-4504: refactor restartPolicyToBool function

In response to this:

This is an automated cherry-pick of #21

/assign elmiko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-1557: refactor restartPolicyToBool function [release-4.12] OCPBUGS-4504: refactor restartPolicyToBool function Dec 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-4504: refactor restartPolicyToBool function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 5, 2022
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-4504, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-1557 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-1557 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #21

/assign elmiko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fedosin for approval by writing /assign @fedosin in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 1e8fa3b link true /test e2e-gcp
ci/prow/goimports 1e8fa3b link true /test goimports
ci/prow/unit 1e8fa3b link true /test unit
ci/prow/e2e-gcp-operator 1e8fa3b link true /test e2e-gcp-operator
ci/prow/govet 1e8fa3b link true /test govet
ci/prow/images 1e8fa3b link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elmiko
Copy link
Contributor

elmiko commented Dec 5, 2022

looks like we are missing the pointer package in here, might have to make this pr manually.

@elmiko
Copy link
Contributor

elmiko commented Dec 6, 2022

closing this in favor of #28

@elmiko elmiko closed this Dec 6, 2022
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-4504. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #21

/assign elmiko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@enxebre enxebre Awaiting requested review from enxebre

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

@elmiko elmiko

Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @elmiko