[release-4.11] OCPBUGS-4579: refactor restartPolicyToBool function

[elmiko]

this is a cherry-pick of #21

to be more thorough about checking for empty string and preemptible instances. previously this function only checked if the value was equal to "Always". but, this misses the default omission case where we should be defaulting to always restart but weren't. additionally, errors have been added when the policy is not recognized or the user attempts to set an always restart policy for a preemptible instance.

fixes OCPBUGS-4579

[openshift-ci-robot]

@elmiko: This pull request references Jira Issue OCPBUGS-4579, which is invalid:

• expected dependent Jira Issue OCPBUGS-4504 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

this is a cherry-pick of #21

to be more thorough about checking for empty string and preemptible instances. previously this function only checked if the value was equal to "Always". but, this misses the default omission case where we should be defaulting to always restart but weren't. additionally, errors have been added when the policy is not recognized or the user attempts to set an always restart policy for a preemptible instance.

fixes OCPBUGS-4579

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@elmiko: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-4579: refactor restartPolicyToBool function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

/lgtm
/approve
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/jira refresh

[openshift-ci-robot]

@JoelSpeed: This pull request references Jira Issue OCPBUGS-4579, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.11.z) matches configured target version for branch (4.11.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-4504 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-4504 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
• bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sunzhaohua2]

/label cherry-pick-approved

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD b62fa85 and 2 for PR HEAD 5d3a84d in total

[openshift-ci]

@elmiko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@elmiko: All pull requests linked via external trackers have merged:

• openshift/machine-api-provider-gcp#30

Jira Issue OCPBUGS-4579 has been moved to the MODIFIED state.

In response to this:

this is a cherry-pick of #21

to be more thorough about checking for empty string and preemptible instances. previously this function only checked if the value was equal to "Always". but, this misses the default omission case where we should be defaulting to always restart but weren't. additionally, errors have been added when the policy is not recognized or the user attempts to set an always restart policy for a preemptible instance.

fixes OCPBUGS-4579

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elmiko]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@elmiko: new pull request created: #36

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-api-provider-gcp-container-v4.11.0-202311211130.p0.g9363d87.assembly.stream for distgit ose-machine-api-provider-gcp.
All builds following this will include this PR.