OCPCLOUD-2191: Update to Kube 1.28 #59
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@nrb: This pull request references OCPCLOUD-2191 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
go.mod
Outdated
| google.golang.org/api v0.114.0 | ||
| k8s.io/api v0.28.2 | ||
| k8s.io/apimachinery v0.28.2 | ||
| k8s.io/client-go v0.28.2 | ||
| k8s.io/klog/v2 v2.100.1 | ||
| k8s.io/utils v0.0.0-20230726121419-3b25d923346b | ||
| sigs.k8s.io/controller-runtime v0.15.0 |
There was a problem hiding this comment.
You may also want to bump the controller-runtime to the latest
| @@ -1,6 +1,6 @@ | |||
| module github.com/openshift/machine-api-provider-gcp | |||
|
|
|||
| go 1.18 | |||
| go 1.20 | |||
There was a problem hiding this comment.
Could you also bump the client-go/library-go/machine-api-operator to their latest main/master branch commits?
|
The import linting is not happy 🤔 |
|
Yeah, I let GoLand do it which doesn't match OpenShift's ordering. I've fixed that, still debugging the termination handler failing |
Also update - controller-runtime - gnostic - openshift/api - openshift/client-go - openshift/library-go - mao Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
@nrb: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Also update the build image to use golang 1.20