Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the component in OWNERS file #36

Merged
merged 1 commit into from Jan 27, 2023

Conversation

fabianofranz
Copy link
Member

@fabianofranz fabianofranz commented Jan 26, 2023

Updates the component entry to match Jira[1] instead of the old Bugzilla component and subcomponent.

[1] https://issues.redhat.com/issues/?jql=project%20%3D%20OCPBUGS%20AND%20component%20%3D%20%22Cloud%20Compute%20%2F%20Nutanix%20Provider%22

@JoelSpeed
Copy link
Contributor

Are we sure removing the subcomponent is the correct thing to do? I know there's automation pulling this information in right now, but I guess it's already handling the subcomponent field?

@fabianofranz
Copy link
Member Author

@brenton can you take a quick look here and confirm?

My understanding is that yes, we'll no longer use the subcomponent field (used to map it to BZ in past) and have the component field matching the one in Jira.

@fabianofranz
Copy link
Member Author

Note the change from plural to singular in "Provider".

component

@brenton
Copy link

brenton commented Jan 26, 2023

Hi @fabianofranz, we learned late yesterday that the prodsec tooling does actually support the "subcomponent" field.

The problem with many of the incorrectly triaged bugs was that "Providers" was lacking an "s" (Joel found this! In some other cases there simply was no mapping at all and it needed to be set up for the first time). This just means you can have it either way: one long component with "/" in it or splitting it out into two fields for the prodsec tooling to join with a "/". It needs to match the correct spelling though. Whichever spelling Joel says for this component is authoritative will be the final answer. :) At this point I can't remember if we settled on "Provider" or "Providers".

@JoelSpeed
Copy link
Contributor

I'm happy to continue with Other Provider now we have a limbo state, I'm planning to add more components anyway as our catch all, catches quite a lot right now

@fabianofranz
Copy link
Member Author

Ack, thank you for the directions.

So I repurposed this to just fix the spelling. @JoelSpeed PTAL.

@JoelSpeed
Copy link
Contributor

I just realised this, sorry, but there is actually a nutanix provider component, can we change this repo to nutanix? https://issues.redhat.com/browse/OCPBUGS-5969?jql=project%20%3D%20OCPBUGS%20AND%20component%20%3D%20%22Cloud%20Compute%20%2F%20Nutanix%20Provider%22

@fabianofranz
Copy link
Member Author

@JoelSpeed good catch! I updated it here and changed the component in the Jira bug.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

@fabianofranz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit df79b27 into openshift:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants