New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the component in OWNERS file #36
Conversation
Are we sure removing the subcomponent is the correct thing to do? I know there's automation pulling this information in right now, but I guess it's already handling the subcomponent field? |
@brenton can you take a quick look here and confirm? My understanding is that yes, we'll no longer use the |
Hi @fabianofranz, we learned late yesterday that the prodsec tooling does actually support the "subcomponent" field. The problem with many of the incorrectly triaged bugs was that "Providers" was lacking an "s" (Joel found this! In some other cases there simply was no mapping at all and it needed to be set up for the first time). This just means you can have it either way: one long component with "/" in it or splitting it out into two fields for the prodsec tooling to join with a "/". It needs to match the correct spelling though. Whichever spelling Joel says for this component is authoritative will be the final answer. :) At this point I can't remember if we settled on "Provider" or "Providers". |
I'm happy to continue with |
Ack, thank you for the directions. So I repurposed this to just fix the spelling. @JoelSpeed PTAL. |
I just realised this, sorry, but there is actually a nutanix provider component, can we change this repo to nutanix? https://issues.redhat.com/browse/OCPBUGS-5969?jql=project%20%3D%20OCPBUGS%20AND%20component%20%3D%20%22Cloud%20Compute%20%2F%20Nutanix%20Provider%22 |
Updates the component entry to match Jira[1] instead of the old Bugzilla component and subcomponent. [1] https://issues.redhat.com/issues/?jql=project%20%3D%20OCPBUGS%20AND%20component%20%3D%20%22Cloud%20Compute%20%2F%20Nutanix%20Provider%22 m
@JoelSpeed good catch! I updated it here and changed the component in the Jira bug. |
@fabianofranz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updates the
component
entry to match Jira[1] instead of the old Bugzilla component and subcomponent.[1] https://issues.redhat.com/issues/?jql=project%20%3D%20OCPBUGS%20AND%20component%20%3D%20%22Cloud%20Compute%20%2F%20Nutanix%20Provider%22