Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-27390: IPI install fails on Nutanix when using DHCP #66

Merged

Conversation

yanhua121
Copy link
Contributor

@yanhua121 yanhua121 commented Feb 8, 2024

OCPBUGS-27390: IPI install fails with etcdInsufficientMembers on Nutanix when using DHCP network

Manually tested the fix in-lab with the DHCP subnet.

This bug fix needs back-port to 4.15, 4.14, 4.13, 4.12 release branches. The customer reported this issue OCPBUGS-27390 is using 4.14.9.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 8, 2024
@openshift-ci-robot
Copy link

@yanhua121: This pull request references Jira Issue OCPBUGS-27390, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-27390: IPI install fails with etcdInsufficientMembers on Nutanix when using DHCP network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 8, 2024
@yanhua121 yanhua121 marked this pull request as draft February 8, 2024 19:08
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2024
@openshift-ci-robot
Copy link

@yanhua121: This pull request references Jira Issue OCPBUGS-27390, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yanhua121
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 8, 2024
@openshift-ci-robot
Copy link

@yanhua121: This pull request references Jira Issue OCPBUGS-27390, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yanhua121 yanhua121 marked this pull request as ready for review February 14, 2024 04:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2024
@openshift-ci-robot
Copy link

@yanhua121: This pull request references Jira Issue OCPBUGS-27390, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

OCPBUGS-27390: IPI install fails with etcdInsufficientMembers on Nutanix when using DHCP network

Manually tested the fix in-lab with the DHCP subnet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RadekManak
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
@yanhua121
Copy link
Contributor Author

/assign @JoelSpeed @elmiko

@yanhua121
Copy link
Contributor Author

@elmiko @JoelSpeed Can you review and see if it is approvable?

@JoelSpeed
Copy link
Contributor

@yanhua121 Any idea why CI is so red? Do you think we can try to get CI working to prove this works?

@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 14, 2024

@yanhua121 Any idea why CI is so red? Do you think we can try to get CI working to prove this works?

@JoelSpeed The CI e2e-nutanix jobs with this PR all passed now.

@yanhua121
Copy link
Contributor Author

/retest-required

@yanhua121
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

@yanhua121: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e98d068 into openshift:main Feb 15, 2024
6 checks passed
@openshift-ci-robot
Copy link

@yanhua121: Jira Issue OCPBUGS-27390: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27390 has been moved to the MODIFIED state.

In response to this:

OCPBUGS-27390: IPI install fails with etcdInsufficientMembers on Nutanix when using DHCP network

Manually tested the fix in-lab with the DHCP subnet.

This bug fix needs back-port to 4.15, 4.14, 4.13, 4.12 release branches. The customer reported this issue OCPBUGS-27390 is using 4.14.9.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yanhua121
Copy link
Contributor Author

/cherrypick release-4.15

@yanhua121
Copy link
Contributor Author

/cherrypick release-4.14

@openshift-cherrypick-robot

@yanhua121: #66 failed to apply on top of branch "release-4.15":

Applying: OCPBUGS-27390: IPI install fails on Nutanix with DHCP network
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-27390: IPI install fails on Nutanix with DHCP network
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@yanhua121: #66 failed to apply on top of branch "release-4.14":

Applying: OCPBUGS-27390: IPI install fails on Nutanix with DHCP network
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	pkg/actuators/machine/machine_scope.go
M	vendor/k8s.io/kubectl/pkg/cmd/util/helpers.go
M	vendor/k8s.io/kubectl/pkg/util/openapi/openapi.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging vendor/k8s.io/kubectl/pkg/util/openapi/openapi.go
Auto-merging vendor/k8s.io/kubectl/pkg/cmd/util/helpers.go
CONFLICT (content): Merge conflict in vendor/k8s.io/kubectl/pkg/cmd/util/helpers.go
Auto-merging pkg/actuators/machine/machine_scope.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-27390: IPI install fails on Nutanix with DHCP network
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-nutanix-machine-controllers-container-v4.16.0-202402151410.p0.ge98d068.assembly.stream.el9 for distgit ose-nutanix-machine-controllers.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants