Revendor CAPO #104
Revendor CAPO #104
Conversation
Point to the `release-4.15` branch of downstream CAPO, that is tracking upstream's `release-0.8` branch. Because the `v0.8.0` tag upstream points to a commit that does not belong to the `release-0.8` branch, we're getting a `v0.8.0-beta-xxx` version in the go mod but this is indeed the stable v0.8 release branch.
|
The diff is minimal and might not be worth backporting. |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
The change in diff prevented a crash of the controller in case of failure to build the machine; it may be interesting to have it imo. I'll let you settle on the /hold; in the meantime, it has my |
|
/retest-required |
|
@mandre: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Point to the
release-4.15branch of downstream CAPO, that is tracking upstream'srelease-0.8branch.Because the
v0.8.0tag upstream points to a commit that does not belong to therelease-0.8branch, we're getting av0.8.0-beta-xxxversion in the go mod but this is indeed the stable v0.8 release branch.