Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-32428: Ensure portSecurity is correctly set in the Instance Ports #109

Open
wants to merge 1 commit into
base: release-4.14
Choose a base branch
from
Open

[release-4.14] OCPBUGS-32428: Ensure portSecurity is correctly set in the Instance Ports #109

wants to merge 1 commit into from

Conversation

MaysaMacedo
Copy link
Contributor

Right now we only enforce portSecurity when it's defined within the Machine's Network field, but the portSecurity in the Machine's ports field should also be enforced. This commit fixes the issue by ensuring the value of PortSecurity is correctly set in the Server port.

@MaysaMacedo
Ensure portSecurity is correctly set in the Instance Ports
794a9b2 
Right now we only enforce portSecurity when it's defined
within the Machine's Network field, but the portSecurity
in the Machine's ports field should also be enforced.
This commit fixes the issue by ensuring the value of
PortSecurity is correctly set in the Server port.
@openshift-ci openshift-ci bot requested review from EmilienM and mdbooth April 18, 2024 14:14
@MaysaMacedo MaysaMacedo changed the title Ensure portSecurity is correctly set in the Instance Ports Bug OCPBUGS-32428: Ensure portSecurity is correctly set in the Instance Ports Apr 18, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Apr 18, 2024
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-32428, which is invalid:

  • expected Jira Issue OCPBUGS-32428 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Right now we only enforce portSecurity when it's defined within the Machine's Network field, but the portSecurity in the Machine's ports field should also be enforced. This commit fixes the issue by ensuring the value of PortSecurity is correctly set in the Server port.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 18, 2024
@MaysaMacedo MaysaMacedo changed the title Bug OCPBUGS-32428: Ensure portSecurity is correctly set in the Instance Ports [release-4.14] OCPBUGS-32428: Ensure portSecurity is correctly set in the Instance Ports Apr 18, 2024
@MaysaMacedo
Copy link
Contributor Author

Manual cherry-pick of #108

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

@MaysaMacedo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MaysaMacedo
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-32428, which is invalid:

  • expected Jira Issue OCPBUGS-32428 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MaysaMacedo
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 9, 2024
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-32428, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-30857 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-30857 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM
Copy link
Member

EmilienM commented May 9, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MaysaMacedo @openshift-ci-robot @EmilienM