Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-10607: Use TenantID if ProjectID is empty #66

Merged
merged 1 commit into from Jul 19, 2023
Merged

OCPBUGS-10607: Use TenantID if ProjectID is empty #66

merged 1 commit into from Jul 19, 2023

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Mar 21, 2023 •
edited

Most CAPO structures only accept a ProjectID. Before this change, the TenantID potentially present in the input filters was ignored. With this change, CAPO is passed the input TenantID if ProjectID is empty.

This is a manual cherry-pick of #62

@pierreprinetti
Use TenantID if ProjectID is empty
5cd0bc7 
Most CAPO structures only accept a ProjectID. Before this change, the
TenantID potentially present in the input filters was ignored. With this
change, CAPO is passed the input TenantID if ProjectID is empty.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

@pierreprinetti: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Use TenantID if ProjectID is empty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

/jira cherrypick OCPBUGS-10298

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: Jira Issue OCPBUGS-10298 has been cloned as Jira Issue OCPBUGS-10607. Will retitle bug to link to clone.
/retitle OCPBUGS-10607: Use TenantID if ProjectID is empty

In response to this:

/jira cherrypick OCPBUGS-10298

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@openshift-ci openshift-ci bot changed the title Use TenantID if ProjectID is empty OCPBUGS-10607: Use TenantID if ProjectID is empty Mar 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

@pierreprinetti: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-10607: Use TenantID if ProjectID is empty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 21, 2023
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Jira Issue OCPBUGS-10607, which is invalid:

  • expected dependent Jira Issue OCPBUGS-10298 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Most CAPO structures only accept a ProjectID. Before this change, the TenantID potentially present in the input filters was ignored. With this change, CAPO is passed the input TenantID if ProjectID is empty.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Jira Issue OCPBUGS-10607, which is invalid:

  • expected dependent Jira Issue OCPBUGS-10298 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Most CAPO structures only accept a ProjectID. Before this change, the TenantID potentially present in the input filters was ignored. With this change, CAPO is passed the input TenantID if ProjectID is empty.

This is a manual cherry-pick of #62

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

@pierreprinetti: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-10607: Use TenantID if ProjectID is empty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stephenfin
stephenfin reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

mandre
mandre reviewed Mar 21, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Mar 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mandre,pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 20, 2023
@stephenfin
Copy link
Contributor

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 27, 2023
@eurijon
Copy link

eurijon commented Jul 19, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 19, 2023
@openshift-ci-robot
Copy link
Contributor

@eurijon: This pull request references Jira Issue OCPBUGS-10607, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10298 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-10298 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from eurijon July 19, 2023 07:10
@eurijon
Copy link

eurijon commented Jul 19, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@pierreprinetti: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit fe08e72 into openshift:release-4.12 Jul 19, 2023
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: Jira Issue OCPBUGS-10607: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10607 has been moved to the MODIFIED state.

In response to this:

Most CAPO structures only accept a ProjectID. Before this change, the TenantID potentially present in the input filters was ignored. With this change, CAPO is passed the input TenantID if ProjectID is empty.

This is a manual cherry-pick of #62

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-07-19-222242

@pierreprinetti pierreprinetti deleted the tenantid_4.12 branch July 23, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@stephenfin stephenfin stephenfin left review comments

@eurijon eurijon Awaiting requested review from eurijon

Assignees

@mandre mandre

@stephenfin stephenfin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pierreprinetti @openshift-ci-robot @openshift-bot @stephenfin @eurijon @openshift-merge-robot @mandre