Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and use k8 1.28 #52

Merged
merged 1 commit into from Sep 27, 2023
Merged

Update dependencies and use k8 1.28 #52

merged 1 commit into from Sep 27, 2023

Conversation

Karthik-K-N
Copy link
Member

@Karthik-K-N Karthik-K-N commented Sep 27, 2023 •
edited

Updated go modules and updated k8 version to 1.27

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@JoelSpeed
Copy link
Contributor

OpenShift is now using 1.28 dependencies, can this be updated to match?

@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Sep 27, 2023 •
edited

OpenShift is now using 1.28 dependencies, can this be updated to match?

sure will do. I saw other providers were at 1.27 so updated to match with them.

@JoelSpeed
Copy link
Contributor

Our intention is to update the other providers in the next sprint

@Karthik-K-N Karthik-K-N changed the title Update dependencies and use k8 1.27 Update dependencies and use k8 1.28 Sep 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2023

@Karthik-K-N: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, Karthik-K-N

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JoelSpeed,Karthik-K-N]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2286e96 into openshift:main Sep 27, 2023
7 checks passed
@Karthik-K-N Karthik-K-N deleted the update-dependencies branch September 27, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Karthik-K-N @JoelSpeed @openshift-merge-robot