Skip to content

Commit

Permalink
update rest of the usage of apiextensions v1beta1 to v1
Browse files Browse the repository at this point in the history
  • Loading branch information
sinnykumari committed May 7, 2021
1 parent 967231b commit 7dc492a
Show file tree
Hide file tree
Showing 12 changed files with 31 additions and 30 deletions.
2 changes: 1 addition & 1 deletion cmd/machine-config-operator/start.go
Expand Up @@ -59,7 +59,7 @@ func runStartCmd(cmd *cobra.Command, args []string) {
ctrlctx.NamespacedInformerFactory.Machineconfiguration().V1().MachineConfigs(),
ctrlctx.NamespacedInformerFactory.Machineconfiguration().V1().ControllerConfigs(),
ctrlctx.KubeNamespacedInformerFactory.Core().V1().ServiceAccounts(),
ctrlctx.APIExtInformerFactory.Apiextensions().V1beta1().CustomResourceDefinitions(),
ctrlctx.APIExtInformerFactory.Apiextensions().V1().CustomResourceDefinitions(),
ctrlctx.KubeNamespacedInformerFactory.Apps().V1().Deployments(),
ctrlctx.KubeNamespacedInformerFactory.Apps().V1().DaemonSets(),
ctrlctx.KubeNamespacedInformerFactory.Rbac().V1().ClusterRoles(),
Expand Down
2 changes: 1 addition & 1 deletion docs/ContainerRuntimeConfigDesign.md
Expand Up @@ -27,7 +27,7 @@ Extend the Machine Config Operator to include a ContainerRuntimeConfig CRD and C
## CRD

```
apiVersion: apiextensions.k8s.io/v1beta1
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
name: containerruntimeconfigs.machineconfiguration.openshift.io
Expand Down
2 changes: 1 addition & 1 deletion docs/KubeletConfigDesign.md
Expand Up @@ -33,7 +33,7 @@ Extend the Machine Config Operator to include a KubetletConfig CRD and KubeletCo
## CRD

```
apiVersion: apiextensions.k8s.io/v1beta1
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
name: kubeletconfigs.machineconfiguration.openshift.io
Expand Down
2 changes: 1 addition & 1 deletion examples/controllerconfig.crd.yaml
@@ -1,4 +1,4 @@
apiVersion: apiextensions.k8s.io/v1beta1
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
# name must match the spec fields below, and be in the form: <plural>.<group>
Expand Down
2 changes: 1 addition & 1 deletion examples/machineconfig.crd.yaml
@@ -1,4 +1,4 @@
apiVersion: apiextensions.k8s.io/v1beta1
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
# name must match the spec fields below, and be in the form: <plural>.<group>
Expand Down
2 changes: 1 addition & 1 deletion examples/machineconfigpool.crd.yaml
@@ -1,4 +1,4 @@
apiVersion: apiextensions.k8s.io/v1beta1
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
# name must match the spec fields below, and be in the form: <plural>.<group>
Expand Down
7 changes: 4 additions & 3 deletions lib/resourceapply/apiext.go
Expand Up @@ -2,15 +2,16 @@ package resourceapply

import (
"context"

"github.com/openshift/machine-config-operator/lib/resourcemerge"
apiextv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
apiextclientv1beta1 "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset/typed/apiextensions/v1beta1"
apiextv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
apiextclientv1 "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset/typed/apiextensions/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

// ApplyCustomResourceDefinition applies the required CustomResourceDefinition to the cluster.
func ApplyCustomResourceDefinition(client apiextclientv1beta1.CustomResourceDefinitionsGetter, required *apiextv1beta1.CustomResourceDefinition) (*apiextv1beta1.CustomResourceDefinition, bool, error) {
func ApplyCustomResourceDefinition(client apiextclientv1.CustomResourceDefinitionsGetter, required *apiextv1.CustomResourceDefinition) (*apiextv1.CustomResourceDefinition, bool, error) {
existing, err := client.CustomResourceDefinitions().Get(context.TODO(), required.Name, metav1.GetOptions{})
if apierrors.IsNotFound(err) {
actual, err := client.CustomResourceDefinitions().Create(context.TODO(), required, metav1.CreateOptions{})
Expand Down
4 changes: 2 additions & 2 deletions lib/resourcemerge/apiext.go
@@ -1,13 +1,13 @@
package resourcemerge

import (
apiextv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
apiextv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
"k8s.io/apimachinery/pkg/api/equality"
)

// EnsureCustomResourceDefinition ensures that the existing matches the required.
// modified is set to true when existing had to be updated with required.
func EnsureCustomResourceDefinition(modified *bool, existing *apiextv1beta1.CustomResourceDefinition, required apiextv1beta1.CustomResourceDefinition) {
func EnsureCustomResourceDefinition(modified *bool, existing *apiextv1.CustomResourceDefinition, required apiextv1.CustomResourceDefinition) {
EnsureObjectMeta(modified, &existing.ObjectMeta, required.ObjectMeta)

// we stomp everything
Expand Down
12 changes: 6 additions & 6 deletions lib/resourceread/apiext.go
@@ -1,7 +1,7 @@
package resourceread

import (
apiextv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
apiextv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime/serializer"
)
Expand All @@ -12,16 +12,16 @@ var (
)

func init() {
if err := apiextv1beta1.AddToScheme(apiExtensionsScheme); err != nil {
if err := apiextv1.AddToScheme(apiExtensionsScheme); err != nil {
panic(err)
}
}

// ReadCustomResourceDefinitionV1Beta1OrDie reads crd object from bytes. Panics on error.
func ReadCustomResourceDefinitionV1Beta1OrDie(objBytes []byte) *apiextv1beta1.CustomResourceDefinition {
requiredObj, err := runtime.Decode(apiExtensionsCodecs.UniversalDecoder(apiextv1beta1.SchemeGroupVersion), objBytes)
// ReadCustomResourceDefinitionV11OrDie reads crd object from bytes. Panics on error.
func ReadCustomResourceDefinitionV1OrDie(objBytes []byte) *apiextv1.CustomResourceDefinition {
requiredObj, err := runtime.Decode(apiExtensionsCodecs.UniversalDecoder(apiextv1.SchemeGroupVersion), objBytes)
if err != nil {
panic(err)
}
return requiredObj.(*apiextv1beta1.CustomResourceDefinition)
return requiredObj.(*apiextv1.CustomResourceDefinition)
}
10 changes: 5 additions & 5 deletions pkg/operator/operator.go
Expand Up @@ -11,8 +11,8 @@ import (
configclientset "github.com/openshift/client-go/config/clientset/versioned"
corev1 "k8s.io/api/core/v1"
apiextclientset "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"
apiextinformersv1beta1 "k8s.io/apiextensions-apiserver/pkg/client/informers/externalversions/apiextensions/v1beta1"
apiextlistersv1beta1 "k8s.io/apiextensions-apiserver/pkg/client/listers/apiextensions/v1beta1"
apiextinformersv1 "k8s.io/apiextensions-apiserver/pkg/client/informers/externalversions/apiextensions/v1"
apiextlistersv1 "k8s.io/apiextensions-apiserver/pkg/client/listers/apiextensions/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
Expand Down Expand Up @@ -69,7 +69,7 @@ type Operator struct {

syncHandler func(ic string) error

crdLister apiextlistersv1beta1.CustomResourceDefinitionLister
crdLister apiextlistersv1.CustomResourceDefinitionLister
mcpLister mcfglistersv1.MachineConfigPoolLister
ccLister mcfglistersv1.ControllerConfigLister
mcLister mcfglistersv1.MachineConfigLister
Expand Down Expand Up @@ -115,7 +115,7 @@ func New(
mcInformer mcfginformersv1.MachineConfigInformer,
controllerConfigInformer mcfginformersv1.ControllerConfigInformer,
serviceAccountInfomer coreinformersv1.ServiceAccountInformer,
crdInformer apiextinformersv1beta1.CustomResourceDefinitionInformer,
crdInformer apiextinformersv1.CustomResourceDefinitionInformer,
deployInformer appsinformersv1.DeploymentInformer,
daemonsetInformer appsinformersv1.DaemonSetInformer,
clusterRoleInformer rbacinformersv1.ClusterRoleInformer,
Expand Down Expand Up @@ -211,7 +211,7 @@ func (optr *Operator) Run(workers int, stopCh <-chan struct{}) {
defer utilruntime.HandleCrash()
defer optr.queue.ShutDown()

apiClient := optr.apiExtClient.ApiextensionsV1beta1()
apiClient := optr.apiExtClient.ApiextensionsV1()
_, err := apiClient.CustomResourceDefinitions().Get(context.TODO(), "controllerconfigs.machineconfiguration.openshift.io", metav1.GetOptions{})
if err != nil {
if apierrors.IsNotFound(err) {
Expand Down
10 changes: 5 additions & 5 deletions pkg/operator/sync.go
Expand Up @@ -16,7 +16,7 @@ import (

appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
apiextv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
apiextv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/labels"
Expand Down Expand Up @@ -290,8 +290,8 @@ func (optr *Operator) syncCustomResourceDefinitions() error {
if err != nil {
return fmt.Errorf("error getting asset %s: %v", crd, err)
}
c := resourceread.ReadCustomResourceDefinitionV1Beta1OrDie(crdBytes)
_, updated, err := resourceapply.ApplyCustomResourceDefinition(optr.apiExtClient.ApiextensionsV1beta1(), c)
c := resourceread.ReadCustomResourceDefinitionV1OrDie(crdBytes)
_, updated, err := resourceapply.ApplyCustomResourceDefinition(optr.apiExtClient.ApiextensionsV1(), c)
if err != nil {
return err
}
Expand Down Expand Up @@ -658,7 +658,7 @@ const (
controllerConfigCompletedTimeout = 5 * time.Minute
)

func (optr *Operator) waitForCustomResourceDefinition(resource *apiextv1beta1.CustomResourceDefinition) error {
func (optr *Operator) waitForCustomResourceDefinition(resource *apiextv1.CustomResourceDefinition) error {
var lastErr error
if err := wait.Poll(customResourceReadyInterval, customResourceReadyTimeout, func() (bool, error) {
crd, err := optr.crdLister.Get(resource.Name)
Expand All @@ -668,7 +668,7 @@ func (optr *Operator) waitForCustomResourceDefinition(resource *apiextv1beta1.Cu
}

for _, condition := range crd.Status.Conditions {
if condition.Type == apiextv1beta1.Established && condition.Status == apiextv1beta1.ConditionTrue {
if condition.Type == apiextv1.Established && condition.Status == apiextv1.ConditionTrue {
return true, nil
}
}
Expand Down
6 changes: 3 additions & 3 deletions test/framework/clientset.go
Expand Up @@ -6,7 +6,7 @@ import (
"github.com/golang/glog"
clientconfigv1 "github.com/openshift/client-go/config/clientset/versioned/typed/config/v1"
clientmachineconfigv1 "github.com/openshift/machine-config-operator/pkg/generated/clientset/versioned/typed/machineconfiguration.openshift.io/v1"
clientapiextensionsv1beta1 "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset/typed/apiextensions/v1beta1"
clientapiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset/typed/apiextensions/v1"
appsv1client "k8s.io/client-go/kubernetes/typed/apps/v1"
corev1client "k8s.io/client-go/kubernetes/typed/core/v1"
"k8s.io/client-go/rest"
Expand All @@ -18,7 +18,7 @@ type ClientSet struct {
appsv1client.AppsV1Interface
clientconfigv1.ConfigV1Interface
clientmachineconfigv1.MachineconfigurationV1Interface
clientapiextensionsv1beta1.ApiextensionsV1beta1Interface
clientapiextensionsv1.ApiextensionsV1Interface
}

// NewClientSet returns a *ClientBuilder with the given kubeconfig.
Expand All @@ -45,7 +45,7 @@ func NewClientSet(kubeconfig string) *ClientSet {
clientSet.CoreV1Interface = corev1client.NewForConfigOrDie(config)
clientSet.ConfigV1Interface = clientconfigv1.NewForConfigOrDie(config)
clientSet.MachineconfigurationV1Interface = clientmachineconfigv1.NewForConfigOrDie(config)
clientSet.ApiextensionsV1beta1Interface = clientapiextensionsv1beta1.NewForConfigOrDie(config)
clientSet.ApiextensionsV1Interface = clientapiextensionsv1.NewForConfigOrDie(config)
clientSet.AppsV1Interface = appsv1client.NewForConfigOrDie(config)

return clientSet
Expand Down

0 comments on commit 7dc492a

Please sign in to comment.