Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baremetal: Bootstrap keepalived should pass --cluster-config #1037

Closed
bcrochet opened this issue Aug 6, 2019 · 1 comment · Fixed by #1043
Closed

baremetal: Bootstrap keepalived should pass --cluster-config #1037

bcrochet opened this issue Aug 6, 2019 · 1 comment · Fixed by #1043
Assignees

Comments

@bcrochet
Copy link
Member

bcrochet commented Aug 6, 2019

A recent change to the installer (openshift/installer@82d81d9) copies kubeconfig-loopback instead of kubeconfig to /etc/kubernetes/kubeconfig.

This causes a problem for baremetal bootstrap. It points to localhost.

Proposed fix is to read from cluster-config.yaml first, and fall back to kubeconfig if that's not available.

The coredns bootstrap pod already passes --cluster-config to baremetal-runtimecfg. Keepalived needs to as well.

Related to openshift/baremetal-runtimecfg#15
Depends on openshift/baremetal-runtimecfg#16

@bcrochet
Copy link
Member Author

bcrochet commented Aug 6, 2019

/assign

bcrochet added a commit to bcrochet/machine-config-operator that referenced this issue Aug 7, 2019
A recent installer change started using a loopback address in kubeconfig
as the default on the bootstrap node. baremetal-runtimecfg will begin
using cluster-config.yml if it exists first, in order to get the domain
and name of the cluster.

This patch adds a flag for this to the keepalived bootstrap pod in order
to utilize it. This should only affect the bootstrap pods.

Fixes openshift#1037
Depends on openshift/baremetal-runtimecfg#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant