Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure HTTP PROXY variables permanently into environment #2271

Closed
EmilienM opened this issue Dec 1, 2020 · 6 comments
Closed

Configure HTTP PROXY variables permanently into environment #2271

EmilienM opened this issue Dec 1, 2020 · 6 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@EmilienM
Copy link
Member

EmilienM commented Dec 1, 2020 •
edited

Description

Proxy variables (HTTP_PROXY, HTTPS_PROXY and
NO_PROXY) are manually set/exported into some bash scripts while it would be beneficial for them to be widely exported on the system; since any application would need access to it (e.g. podman, etc).

Note
It is mainly a follow-up of #2266.

Reference
Related BZ
@EmilienM EmilienM mentioned this issue Dec 1, 2020
Merged
@EmilienM EmilienM mentioned this issue Dec 1, 2020
Closed
EmilienM added a commit to shiftstack/machine-config-operator that referenced this issue Dec 18, 2020
@EmilienM
[common] inject proxy into system wide environment
a70ede3 
Following the official manual:
https://coreos.com/os/docs/latest/using-environment-variables-in-systemd-units.html#other-examples

In order to load the proxy variables (HTTP_PROXY, HTTPS_PROXY and
NO_PROXY), we now load them at systemd level and in a profile for system
wide impact.

By doing so, we allow the proxy to be used generally by all the services
or commands which look for them.

Closes openshift#2271
Signed-off-by: Emilien Macchi <emilien@redhat.com>
@kikisdeliveryservice
Copy link
Contributor

Linked PR and underlying BZ are both merged. Closing.

@kikisdeliveryservice
Copy link
Contributor

Sorry, a bit of confusion on my part the underlying PR is actually:
#2272

Reopening.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 5, 2021
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 5, 2021
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Jun 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2021

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[common] inject proxy into system wide environment shiftstack/machine-config-operator
4 participants
@EmilienM @openshift-bot @kikisdeliveryservice @openshift-ci-robot