-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garbage collect old generated MachineConfigs #354
Comments
/kind enhancement |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Right now, previously generated MachineConfigs just hang around forever. We need to figure out how to clean them safely. There was related code in the render controller (see #318) that deleted the ownerRef of the pool on other MachineConfigs, but it didn't actually work (and anyway removing an ownerReference in itself doesn't trigger Kubernetes to delete the MC). The tricky part here is making sure we don't delete MCs that are still used by any MCD instance (where "used" means as a current, pending, or desired config).
Related: #301
Related: #318
Related: #347
The text was updated successfully, but these errors were encountered: