Bug 1738831: pkg/controller/node: resync all pools for a node #1049
Conversation
openshift-ci-robot
added
size/M
runcom
changed the title
|
@runcom: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/hold works but there's a gotcha exposed from unit tests |
openshift-ci-robot
added
the
do-not-merge/hold
When a node belongs to more than one pool, we need to trigger a resync for all the pools it belongs to or we leave the "parent" MCP at an old state. The easy example would be to create an infra pool of just 1 node and describe the worker mcp and notice that it still has all nodes (including the now-infra node). Signed-off-by: Antonio Murdaca <runcom@linux.com>
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
openshift-ci-robot
added
size/L
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@runcom: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When a node belongs to more than one pool, we need to trigger a resync
for all the pools it belongs to or we leave the "parent" MCP at an old
state. The easy example would be to create an infra pool of just 1
node and describe the worker mcp and notice that it still has all nodes
(including the now-infra node).
Signed-off-by: Antonio Murdaca runcom@linux.com