Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1766514: [release-4.2] pkg/daemon: remove force validation file if it exists #1148

Merged
merged 1 commit into from Jan 9, 2020
Merged

Bug 1766514: [release-4.2] pkg/daemon: remove force validation file if it exists #1148

merged 1 commit into from Jan 9, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1114

/assign runcom

@runcom
pkg/daemon: remove force validation file if it exists
309a73c 
Even if we document that the file needs to be removed it sounds like the
MCD should do it itself if the force validation file exists. The case
would be someone forgetting to remove the file causing validation to
always be skipped, even on upgrades.

Signed-off-by: Antonio Murdaca <runcom@linux.com>
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.2] pkg/daemon: remove force validation file if it exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 2, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2019
@rphillips
Copy link
Contributor

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019
@kikisdeliveryservice
Copy link
Contributor

/retest

@kikisdeliveryservice
Copy link
Contributor

@runcom: This needs a BZ to backport to 4.2.z

@eparis
Copy link
Member

eparis commented Oct 26, 2019

/retest
What bug number if this try to fix? It needs to be in the title.
We also need team review/lgtm/approval

@cgwalters
Copy link
Member

What bug number if this try to fix? It needs to be in the title.

Yeah we should file a bug. I commented here too
#1114 (comment)

/approve
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, openshift-cherrypick-robot, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@runcom runcom changed the title [release-4.2] pkg/daemon: remove force validation file if it exists Bug 1766514: [release-4.2] pkg/daemon: remove force validation file if it exists Oct 29, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1766514, which is invalid:

  • expected dependent Bugzilla bug 1766513 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1766514: [release-4.2] pkg/daemon: remove force validation file if it exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 29, 2019
@kikisdeliveryservice
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 8, 2020
@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: This pull request references Bugzilla bug 1766514, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5dd410d into openshift:release-4.2 Jan 9, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1766514 has been moved to the MODIFIED state.

In response to this:

Bug 1766514: [release-4.2] pkg/daemon: remove force validation file if it exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorbusChris LorbusChris Awaiting requested review from LorbusChris

@runcom runcom Awaiting requested review from runcom

Assignees

@rphillips rphillips

@cgwalters cgwalters

@runcom runcom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@openshift-cherrypick-robot @openshift-ci-robot @rphillips @kikisdeliveryservice @eparis @cgwalters @openshift-bot @mrunalp @runcom @openshift-merge-robot